[SERVER-30546] Use Command::filterCommandReplyForPassthrough() for filtering response in ShardRemote::_runCommand Created: 07/Aug/17  Updated: 27/Oct/23  Resolved: 11/Aug/17

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Misha Tyulenev Assignee: Hugh Han
Resolution: Works as Designed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Sharding 2017-08-21
Participants:
Linked BF Score: 0

 Description   

The ShardRemote nees to filter passthrough fields on the propagating response back to config server. instead of
https://github.com/mongodb/mongo/blob/r3.5.11/src/mongo/s/client/shard_remote.cpp#L225-L226
it needs to use the Command::filterCommandReplyForPassthrough



 Comments   
Comment by Misha Tyulenev [ 11/Aug/17 ]

This works as designed the command fields should not be filtered in the ShardRemote but instead it should be done at the location that calls Shard::runCommand if it intends to process it further

Comment by Githook User [ 10/Aug/17 ]

Author:

{'username': 'hughhan1', 'email': 'hughhan1@gmail.com', 'name': 'Hugh Han'}

Message: Revert "SERVER-30546 Use Command::filterCommandReplyForPassthrough() for filtering response in ShardRemote::_runCommand"

This reverts commit 30688eaf7e47e5ed70dae50b73589f668d895722.
Branch: master
https://github.com/mongodb/mongo/commit/6e4604101b8cca0dbab08ba386b56b6ad882292f

Comment by Githook User [ 10/Aug/17 ]

Author:

{'username': 'hughhan1', 'email': 'hughhan1@gmail.com', 'name': 'Hugh Han'}

Message: SERVER-30546 Use Command::filterCommandReplyForPassthrough() for filtering response in ShardRemote::_runCommand
Branch: master
https://github.com/mongodb/mongo/commit/30688eaf7e47e5ed70dae50b73589f668d895722

Generated at Thu Feb 08 04:24:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.