[SERVER-30634] Git detects all files as having changed on Windows causing burn_in_tests task to time out in Evergreen Created: 14/Aug/17 Updated: 30/Oct/23 Resolved: 16/Nov/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 3.4.11, 3.6.0-rc5, 3.7.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Max Hirschhorn | Assignee: | Yves Duhem |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | disabled-test | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Operating System: | Windows | ||||||||||||||||
| Backport Requested: |
v3.6, v3.4
|
||||||||||||||||
| Sprint: | TIG 2017-10-23, TIG 2017-11-13, TIG 2017-12-04 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
See this Evergreen task timeout as an example. My initial suspicion was that core.autocrlf wasn't being set to true when we cloned repositories in Evergreen on Windows, so I tried out the following patch in an Evergreen patch build. Had I tested it out locally, I would have immediately found out that specifying the --name-only to git diff causes it to ignore the --ignore-space-at-eol option and still display the names of files whose only changes are LF -> CRLF. (git diff --ignore-space-at-eol correctly generates no output though.)
Further investigation is still needed, but I'm filing this ticket so that we can temporarily disable the burn_in_tests task on the "Windows 2008R2 DEBUG" builder rather than reverting the changes from |
| Comments |
| Comment by Githook User [ 17/Jan/18 ] |
|
Author: {'name': 'Yves Duhem', 'email': 'yves.duhem@mongodb.com', 'username': 'syev'}Message: (cherry picked from commit 7969a3e83d918a9a3ccaae65c6509b1abad4b34e) Also includes the following related fix: |
| Comment by Githook User [ 16/Nov/17 ] |
|
Author: {'name': 'Yves Duhem', 'username': 'syev', 'email': 'yves.duhem@mongodb.com'}Message: (cherry picked from commit 6b815203b752f4a1e1f8f810b7dda5e0a331b4ea) |
| Comment by Yves Duhem [ 16/Nov/17 ] |
|
After extracting the artifacts in the repository directory, git 1.9.5 on windows listed all the files as changed (using 'git diff --name-only') even though 'git diff' displayed the correct changes. We worked around this git issue by cloning the repository in a separate directory and only copying the dbtest executable in the cloned directory. |
| Comment by Githook User [ 16/Nov/17 ] |
|
Author: {'name': 'Yves Duhem', 'username': 'syev', 'email': 'yves.duhem@mongodb.com'}Message: |
| Comment by Jonathan Abrahams [ 18/Oct/17 ] |
|
yves.duhem Please ensure that you add "set up virtualenv" into the burn_in task. |
| Comment by Githook User [ 14/Aug/17 ] |
|
Author: {'name': 'Max Hirschhorn', 'username': 'visemet', 'email': 'max.hirschhorn@mongodb.com'}Message: |