[SERVER-30647] Modify the 3rd party JSON Schema test suite to only test keywords supported by MongoDB Created: 14/Aug/17  Updated: 30/Oct/23  Resolved: 19/Sep/17

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: 3.6.0-rc0

Type: Task Priority: Major - P3
Reporter: Nicholas Zolnierz Assignee: Nicholas Zolnierz
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Query 2017-10-02
Participants:

 Description   

There are several tasks as part of this ticket:

1. Rename instances of the keyword "integer" to "number" in the JSON Schema test suite, as MongoDB does not support "integer". Remove or modify individual test cases if they expect integer functionality.
2. Update the json_schema_test_runner to validate test cases against a top-level schema when appropriate (data must be a document).
3. As a consequence of #2, certain test cases that don't expect an _id field will need to be modified.



 Comments   
Comment by Githook User [ 18/Sep/17 ]

Author:

{'username': 'nzolnierzmdb', 'name': 'Nick Zolnierz', 'email': 'nicholas.zolnierz@mongodb.com'}

Message: SERVER-30647: Modify the 3rd party JSON Schema test suite to only test keywords supported by MongoDB
Branch: master
https://github.com/mongodb/mongo/commit/7b3d369d8ed11e0c998c09d19aa37ed3e721b425

Comment by David Storch [ 07/Sep/17 ]

Also as part of this ticket, please look into modifying json_schema_test_runner.js to run an additional test which avoids the schema_test_wrapper field when the data is an object.

Comment by David Storch [ 07/Sep/17 ]

nicholas.zolnierz, looks like all that you need to do here is figure out how to enable tests which are disabled only because of their use of type: integer. We should either modify the vendorized JSON Schema test suite or modify our test runner in some fashion to avoid type: integer. Please consult with the platforms team on best practices if we believe that the former approach is best.

Generated at Thu Feb 08 04:24:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.