[SERVER-30748] Alternative to '_inlock' function naming Created: 18/Aug/17 Updated: 30/Oct/23 Resolved: 30/Aug/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 3.5.13 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Nathan Myers | Assignee: | Nathan Myers |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Participants: | |||||||||
| Description |
|
WithLock is for use solely to declare a dummy argument to functions that must be called while It may be used to modernize code from (something like) this
to
The call to such a function looks like this:
Note that the formal argument need not (and should not) be named unless it is needed to pass
~ |
| Comments |
| Comment by Githook User [ 25/Aug/17 ] |
|
Author: {'email': 'ncm@cantrip.org', 'name': 'Nathan Myers', 'username': 'ncm'}Message: |
| Comment by Robert Guo (Inactive) [ 24/Aug/17 ] |
|
https://github.com/mongodb/mongo/commit/82b9a76cd28d1687583c2ff98c63897c4d434668 |
| Comment by Ramon Fernandez Marina [ 24/Aug/17 ] |
|
Author: {'username': u'guoyr', 'name': u'Robert Guo', 'email': u'robert.guo@10gen.com'}Message:Revert " This reverts commit 4c62f2f3bf028abc14a2c5cf6a1f35f507b7e04c. |
| Comment by Ramon Fernandez Marina [ 24/Aug/17 ] |
|
Author: {'username': u'guoyr', 'name': u'Robert Guo', 'email': u'robert.guo@10gen.com'}Message:Revert " This reverts commit 200d56c6eec8acdc6cddf0541f31c60f4ed2e760. |
| Comment by Ramon Fernandez Marina [ 24/Aug/17 ] |
|
Author: {'username': u'ncm', 'name': u'Nathan Myers', 'email': u'ncm@cantrip.org'}Message: |
| Comment by Ramon Fernandez Marina [ 24/Aug/17 ] |
|
Author: {'username': u'ncm', 'name': u'Nathan Myers', 'email': u'ncm@cantrip.org'}Message: |