[SERVER-30862] ReplSetTest.remove() should call stop() on the node to be removed Created: 28/Aug/17 Updated: 30/Oct/23 Resolved: 05/May/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | 3.5.13 |
| Fix Version/s: | 4.7.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Eric Milkie | Assignee: | Jason Chan |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | Repl 2020-05-04, Repl 2020-05-18 |
| Participants: |
| Description |
This crash occurs after the following steps:
|
| Comments |
| Comment by Githook User [ 05/May/20 ] |
|
Author: {'name': 'Jason Chan', 'email': 'jason.chan@10gen.com', 'username': 'jasonjhchan'}Message: |
| Comment by Jason Chan [ 30/Apr/20 ] |
|
I was able to reproduce this on v4.5. I believe it makes sense to have remove() call stop() on the node. |
| Comment by Siyuan Zhou [ 09/Apr/20 ] |
|
In Safe Reconfig project, we usually restore the config to the original config. I think one reason is to avoid problems like this one. We should make ReplSetTest smarter to handle removed nodes. |
| Comment by Jack Mulrow [ 15/Sep/17 ] |
|
I accidentally committed |
| Comment by Ramon Fernandez Marina [ 15/Sep/17 ] |
|
Author: {'username': u'jsmulrow', 'name': u'Jack Mulrow', 'email': u'jack.mulrow@mongodb.com'}Message: |
| Comment by Ramon Fernandez Marina [ 15/Sep/17 ] |
|
Author: {'username': u'jsmulrow', 'name': u'Jack Mulrow', 'email': u'jack.mulrow@mongodb.com'}Message:Revert " This reverts commit 6dded939c14a072d6b15a47a692ba13c706d8db1. |
| Comment by Eric Milkie [ 28/Aug/17 ] |
|
It turns out that ReplSetTest.remove(foo) cannot be called before first calling ReplSetTest.stop(foo). tags2.js is one such test that is following the rules. |