[SERVER-30878] rocksdb (mongo-rocks) compilation failure Created: 29/Aug/17  Updated: 30/Oct/23  Resolved: 30/Aug/17

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 3.5.13

Type: Bug Priority: Major - P3
Reporter: Daniel Gottlieb (Inactive) Assignee: Daniel Gottlieb (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Storage 2017-09-11
Participants:

 Description   

Fix the method signatures to accommodate API changes for timestamps.

In file included from src/mongo/db/modules/rocksdb/src/rocks_record_store.h:42:0,
                 from src/mongo/db/modules/rocksdb/src/rocks_record_store.cpp:34:
src/mongo/db/storage/record_store.h:374:34: error: 'virtual mongo::StatusWith<mongo::RecordId> mongo::RecordStore::insertRecord(mongo::OperationContext*, const char*, int, mongo::Timestamp, bool)' was hidden [-Werror=overloaded-virtual]
     virtual StatusWith<RecordId> insertRecord(OperationContext* opCtx,
                                  ^
In file included from src/mongo/db/modules/rocksdb/src/rocks_record_store.cpp:34:0:
src/mongo/db/modules/rocksdb/src/rocks_record_store.h:139:38: error:   by 'virtual mongo::StatusWith<mongo::RecordId> mongo::RocksRecordStore::insertRecord(mongo::OperationContext*, const char*, int, bool)' [-Werror=overloaded-virtual]
         virtual StatusWith<RecordId> insertRecord( OperationContext* opCtx,
                                      ^
In file included from src/mongo/db/modules/rocksdb/src/rocks_record_store.h:42:0,
                 from src/mongo/db/modules/rocksdb/src/rocks_record_store.cpp:34:
src/mongo/db/storage/record_store.h:408:20: error: 'virtual mongo::Status mongo::RecordStore::insertRecordsWithDocWriter(mongo::OperationContext*, const mongo::DocWriter* const*, const mongo::Timestamp*, size_t, mongo::RecordId*)' was hidden [-Werror=overloaded-virtual]
     virtual Status insertRecordsWithDocWriter(OperationContext* opCtx,
                    ^
In file included from src/mongo/db/modules/rocksdb/src/rocks_record_store.cpp:34:0:
src/mongo/db/modules/rocksdb/src/rocks_record_store.h:144:24: error:   by 'virtual mongo::Status mongo::RocksRecordStore::insertRecordsWithDocWriter(mongo::OperationContext*, const mongo::DocWriter* const*, size_t, mongo::RecordId*)' [-Werror=overloaded-virtual]
         virtual Status insertRecordsWithDocWriter(OperationContext* opCtx,
                        ^



 Comments   
Comment by Daniel Gottlieb (Inactive) [ 30/Aug/17 ]

https://github.com/mongodb-partners/mongo-rocks/commit/7f453075b53548697e33692b76ba2451f38e9630

Generated at Thu Feb 08 04:25:19 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.