[SERVER-31093] Remove initialsync attempts from passthrough suites Created: 14/Sep/17  Updated: 30/Oct/23  Resolved: 23/Jan/18

Status: Closed
Project: Core Server
Component/s: Replication, Testing Infrastructure
Affects Version/s: 3.5.13
Fix Version/s: 3.7.2

Type: Improvement Priority: Major - P3
Reporter: Robert Guo (Inactive) Assignee: Robert Guo (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
depends on SERVER-4941 collection rename may not replicate /... Closed
Problem/Incident
Related
related to SERVER-33063 Use numInitialSyncAttempts=1 in the r... Backlog
related to SERVER-33060 Increase initial sync attempts in ini... Closed
is related to SERVER-26347 reduce number of retry attempts for t... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v3.6
Sprint: TIG 2018-1-29
Participants:
Linked BF Score: 8

 Description   

Initial sync no longer fails when first connecting to a replica set, so we should remove the retry logic from the initial sync and resync passthrough suite definitions:

numInitialSyncAttempts: 2
numInitialSyncConnectAttempts: 60



 Comments   
Comment by Githook User [ 23/Jan/18 ]

Author:

{'name': 'Robert Guo', 'email': 'robert.guo@10gen.com', 'username': 'guoyr'}

Message: SERVER-31093 Remove initialsync attempts from the initial sync suites
Branch: master
https://github.com/mongodb/mongo/commit/3660fcbd6f9dfae8c55b4a0853f1684c0e6fd941

Comment by Robert Guo (Inactive) [ 10/Jan/18 ]

Re Max's questions:

1. numInitialSyncConnectAttempts was 60 to allow slower machines more time to respond.
2. I don't know of the exact ticket that fixed it, but it was a known undesirable behavior at the time and might have been fixed alongside other things broken in initial sync at the time. I would expect changing the number of attempts to 1 to just work. If not, I'll ask for additional clarification from the replication team.

Comment by Max Hirschhorn [ 29/Dec/17 ]

We should also specify numInitialSyncAttempt=1 in the following test suites if it isn't specified already because the default value is 10 attempts. Given the changes from SERVER-4941 in MongoDB 3.6, we should no longer need to have mongod retry the initial sync attempt on a "renameCollection" command and it ought to work on the first attempt.

  • replica_sets_initsync_jscore_passthrough.yml
  • replica_sets_initsync_static_jscore_passthrough.yml
  • replica_sets_resync_static_jscore_passthrough.yml

Separately, robert.guo:

  1. Do you recall why replica_sets_initsync_jscore_passthrough.yml doesn't specify numInitialSyncConnectAttempts=60 and instead uses the default value of 10 attempts? I saw it was added to the other jsCore initial sync test suites in 63640ef as part of judah.schvimer's changes from SERVER-25252.
  2. Do you know what changed since your patch build attempt for SERVER-26347 that makes this ticket possible now?
Generated at Thu Feb 08 04:25:58 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.