[SERVER-31226] ensure or enforce that ShardingTest.stop() is called in all tests that start a ShardingTest Created: 22/Sep/17  Updated: 23/Sep/19  Resolved: 07/Mar/18

Status: Closed
Project: Core Server
Component/s: Sharding, Testing Infrastructure
Affects Version/s: 3.5.13
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Esha Maharishi (Inactive) Assignee: DO NOT USE - Backlog - Test Infrastructure Group (TIG)
Resolution: Duplicate Votes: 0
Labels: todo_in_code
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates SERVER-25640 Have ReplSetTest run checkDBHashes() ... Closed
Related
related to SERVER-43522 Complete TODO listed in SERVER-31226 Closed
Participants:

 Description   

The check that UUIDs are consistent across a cluster was placed in ShardingTest.stop() under SERVER-30511.

It was intended to provide passthrough coverage that UUIDs are always consistent in a cluster, by running at the end of every test that starts a ShardingTest.

However, only tests that actually call ShardingTest.stop() will perform the check.

Should we:

  • audit all jstests to ensure they call ShardingTest.stop() if they start a ShardingTest
  • place some kind of lint or compile check to ensure any future tests call ShardingTest.stop() if they start a ShardingTest?


 Comments   
Comment by Max Hirschhorn [ 21/Feb/18 ]

Closing as a duplicate of SERVER-25640 because the changes from 8821cdb has made it so that the mongo shell exits with a non-zero return code if any processes are still running at the end of a passing JavaScript test. Thanks a bunch kevin.albertson!

Generated at Thu Feb 08 04:26:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.