[SERVER-31233] Session should invalidate _lastWrittenSessionRecord when it detects inconsistency during updateSessionEntry Created: 22/Sep/17  Updated: 30/Oct/23  Resolved: 26/Sep/17

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: 3.5.13
Fix Version/s: 3.6.0-rc0

Type: Bug Priority: Major - P3
Reporter: Randolph Tan Assignee: Randolph Tan
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:
Linked BF Score: 0

 Comments   
Comment by Githook User [ 26/Sep/17 ]

Author:

{'email': 'randolph@10gen.com', 'name': 'Randolph Tan', 'username': 'renctan'}

Message: SERVER-31233 Make session_catalog_migration_destination_test do an actual insert

instead of calling onWriteOpCompletedOnPrimary directly, as there is race where the migration thread might try to retrieve the oplog with the dummy timestamp.
Branch: master
https://github.com/mongodb/mongo/commit/457ecaf9ca73456df43e442ddd758b9067a6a002

Comment by Githook User [ 25/Sep/17 ]

Author:

{'email': 'kaloian.manassiev@mongodb.com', 'name': 'Kaloian Manassiev', 'username': 'kaloianm'}

Message: SERVER-31233 Always advance the last written session record cache after a write

The session transaction cache must move in lock step with the disk writes
and this is independent with the changes to the active transaction number.

This change also reverts commit 74c1946fb05b9fe955f84edd1cc441394bbe6ccf.
Branch: master
https://github.com/mongodb/mongo/commit/fbea0197073ec8e8fb4f9588b4d3f01fd80514ca

Comment by Kaloian Manassiev [ 22/Sep/17 ]

There should never be inconsistency during updateSessionEntry, because all modifications go through the cache and it is the cache that is moving it forward. Is it possible that these tests are making incorrect assumptions?

Comment by Githook User [ 22/Sep/17 ]

Author:

{'email': 'randolph@10gen.com', 'name': 'Randolph Tan', 'username': 'renctan'}

Message: SERVER-31233 Temporarily disable tests in session_catalog_migration_destination_test that races with the migrate thread in modifying the session catalog
Branch: master
https://github.com/mongodb/mongo/commit/74c1946fb05b9fe955f84edd1cc441394bbe6ccf

Generated at Thu Feb 08 04:26:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.