[SERVER-31245] Inserts to "system.indexes" bypass the check for retryability Created: 25/Sep/17  Updated: 30/Oct/23  Resolved: 07/Jun/19

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.3.1

Type: Bug Priority: Major - P3
Reporter: Jack Mulrow Assignee: Alexander Taskov (Inactive)
Resolution: Fixed Votes: 0
Labels: PM-257, ShardingTechDebt, open_todo_in_code
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
depends on SERVER-36015 Remove references to system.namespace... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.2
Sprint: Sharding 2019-06-03, Sharding 2019-06-17
Participants:

 Description   

Right now if an insert is to "system.indexes" it calls performCreateIndexes before the check for retryability for regular inserts. This means a retry of a successful insert to that collection will not be skipped and will call createIndexes again. We should either add retry checking to performCreateIndexes or uassert if an insert to "system.indexes" contains a txnNumber since the operation can't be retried.

Failing retryable_writes_jscore_passthrough tests:

  • batch_write_command_insert.js


 Comments   
Comment by Alexander Taskov (Inactive) [ 07/Jun/19 ]

https://github.com/mongodb/mongo/commit/5ca5038f731819dbeea5163a3932665e25ab3cd5

Comment by Dianna Hohensee (Inactive) [ 07/Aug/18 ]

This impediment will go away with SERVER-36015, which removes the index code in the write path. There are TODOs in suite yml files with this server ticket number, disabling JS tests. This ticket should re-enable them after SERVER-36015 is complete.

Generated at Thu Feb 08 04:26:25 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.