[SERVER-31245] Inserts to "system.indexes" bypass the check for retryability Created: 25/Sep/17 Updated: 30/Oct/23 Resolved: 07/Jun/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Jack Mulrow | Assignee: | Alexander Taskov (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | PM-257, ShardingTechDebt, open_todo_in_code | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Backport Requested: |
v4.2
|
||||||||||||
| Sprint: | Sharding 2019-06-03, Sharding 2019-06-17 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
Right now if an insert is to "system.indexes" it calls performCreateIndexes before the check for retryability for regular inserts. This means a retry of a successful insert to that collection will not be skipped and will call createIndexes again. We should either add retry checking to performCreateIndexes or uassert if an insert to "system.indexes" contains a txnNumber since the operation can't be retried. Failing retryable_writes_jscore_passthrough tests:
|
| Comments |
| Comment by Alexander Taskov (Inactive) [ 07/Jun/19 ] |
|
https://github.com/mongodb/mongo/commit/5ca5038f731819dbeea5163a3932665e25ab3cd5 |
| Comment by Dianna Hohensee (Inactive) [ 07/Aug/18 ] |
|
This impediment will go away with |