[SERVER-31316] Remove unused code for KeysCollectionManager* classes Created: 28/Sep/17  Updated: 30/Oct/23  Resolved: 13/Dec/17

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 3.7.1

Type: Task Priority: Major - P3
Reporter: Misha Tyulenev Assignee: Kaitlin Mahar
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-31506 Get rid of stale code in KeysCollecti... Closed
Backwards Compatibility: Fully Compatible
Sprint: Sharding 2017-12-18
Participants:

 Description   

There are KeysCollectionManagerDirect, KeysCollectionManagerZero that are not used anywhere.
Will be removing their corresponding .h and .cpp files, and renaming KeyCollectionManagerSharding to KeyCollectionManager to avoid the unnecessary inheritance.

Also remove inclusion of keys_collection_manager_zero.h from src/mongo/db/service_liason.cpp.



 Comments   
Comment by Githook User [ 13/Dec/17 ]

Author:

{'name': 'Kaitlin Mahar', 'email': 'kaitlin.mahar@mongodb.com', 'username': 'kmahar'}

Message: SERVER-31316 Remove unused code and unnecessary inheritance in KeysCollectionManager* classes
Branch: master
https://github.com/mongodb/mongo/commit/65c64a7845ca8159028148b25d3ec1867158108d

Comment by Kaitlin Mahar [ 07/Dec/17 ]

samantha.ritter I see you added the include for keys_collection_manager_zero.h in service_liason.cpp. Are the proposed changes ok with you?

Comment by Randolph Tan [ 02/Oct/17 ]

misha.tyulenev Sounds good to me

Comment by Misha Tyulenev [ 28/Sep/17 ]

renctan wdyt?

Generated at Thu Feb 08 04:26:38 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.