[SERVER-31498] Make build (nearly) clang-5.0 clean Created: 10/Oct/17  Updated: 30/Oct/23  Resolved: 22/Nov/17

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 3.7.1

Type: Improvement Priority: Trivial - P5
Reporter: Sara Golemon Assignee: Sara Golemon
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-34328 Build fails due to clang 9.1's -Wunus... Closed
Backwards Compatibility: Fully Compatible
Participants:

 Description   

clang-5.0 introduces several new code warnings which mongod does not pass.

Three of these failures are bugs in clang and have been reported at https://bugs.llvm.org/show_bug.cgi?id=34804 and https://bugs.llvm.org/show_bug.cgi?id=34865

The remaining are legitimate (but minor) issues in our codebase that should be cleaned up.



 Comments   
Comment by Githook User [ 29/Nov/17 ]

Author:

{'name': 'Sara Golemon', 'username': 'sgolemon', 'email': 'sara.golemon@mongodb.com'}

Message: SERVER-31498 Partial revert; keep ignoring unused-lambda-capture
Branch: master
https://github.com/mongodb/mongo/commit/fe8890ff6718850af6082441c62fd6cdfb67e3f4

Comment by Githook User [ 22/Nov/17 ]

Author:

{'name': 'Sara Golemon', 'username': 'sgolemon', 'email': 'sara.golemon@mongodb.com'}

Message: SERVER-31498 Make build more clang5 friendly

  • Remove unused lambda capture variables
  • Resolve signed/unsigned comparisons
  • Apply upstream MozJS bugfix 1390214 [1]

1 - https://github.com/mozilla/gecko-dev/commit/a6da168bd0cd41d4b5dd2a0560490ec2ae33d5f7#diff-56d2d8dc33027ea7d747c116640db8ac
Branch: master
https://github.com/mongodb/mongo/commit/cd3e3011158cab7dbf5d2fed86641c8f0b8b88fb

Generated at Thu Feb 08 04:27:15 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.