[SERVER-31531] feature compatibility version writes must check for writeErrors Created: 12/Oct/17  Updated: 30/Oct/23  Resolved: 18/Oct/17

Status: Closed
Project: Core Server
Component/s: Replication, Write Ops
Affects Version/s: 3.4.9, 3.5.13
Fix Version/s: 3.4.11, 3.6.0-rc1

Type: Bug Priority: Major - P3
Reporter: Judah Schvimer Assignee: Tess Avitabile (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
is depended on by SERVER-31189 fassert if feature compatibility vers... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v3.4
Sprint: Query 2017-10-23
Participants:

 Description   

Here: https://github.com/mongodb/mongo/blob/c617c3efabb7ee6da6ec66fe9f585dfaeed631df/src/mongo/db/commands/feature_compatibility_version.cpp#L327-L332 we have:

    // Update the featureCompatibilityVersion document stored in the "admin.system.version"
    // collection.
    BSONObj updateResult;
    client.runCommand(nss.db().toString(), updateCmd.obj(), updateResult);
    uassertStatusOK(getStatusFromCommandResult(updateResult));
    uassertStatusOK(getWriteConcernStatusFromCommandResult(updateResult));

Since this is doing an update, it can return a status like the following with ok:1 but a write error indicating that we should fail:

{ n: 0, nModified: 0, writeErrors: [ { index: 0, code: 62, errmsg: "Must be in primary or secondary state to downgrade feature compatibility version document { _id: "featureCompatibilityVersion", version: "3.4", targetV..." } ], ok: 1.0 }



 Comments   
Comment by Githook User [ 10/Nov/17 ]

Author:

{'name': 'Tess Avitabile', 'username': 'tessavitabile', 'email': 'tess.avitabile@mongodb.com'}

Message: SERVER-31531 featureCompatibilityVersion writes must check for writeErrors

(cherry picked from commit ddacafb22591d831f2b320b196c2809193a52d05)
Branch: v3.4
https://github.com/mongodb/mongo/commit/b6132d87fe4c108dfb0c94980a49d97406b42dce

Comment by Githook User [ 18/Oct/17 ]

Author:

{'email': 'tess.avitabile@mongodb.com', 'name': 'Tess Avitabile', 'username': 'tessavitabile'}

Message: SERVER-31531 featureCompatibilityVersion writes must check for writeErrors
Branch: master
https://github.com/mongodb/mongo/commit/ddacafb22591d831f2b320b196c2809193a52d05

Generated at Thu Feb 08 04:27:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.