[SERVER-31585] Remove PeriodicBalancerSettingsRefresher that is both unused and incorrectly set up Created: 16/Oct/17  Updated: 30/Oct/23  Resolved: 18/Oct/17

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 3.6.0-rc1

Type: Improvement Priority: Major - P3
Reporter: Dianna Hohensee (Inactive) Assignee: Dianna Hohensee (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-31518 There is no way to safely register a ... Closed
is depended on by SERVER-31537 PeriodicBalancerSettingsRefresher::_p... Closed
Backwards Compatibility: Fully Compatible
Sprint: Sharding 2017-10-23
Participants:
Linked BF Score: 0

 Description   

PeriodicBalancerSettingsRefresher is currently unused because it was added as part of the intern autosplit project that didn't get finished over the summer.

It has two problems
1) It is instantiated incorrectly. It registers a shutdown task during sharding initialization, which can cause a crash if we're already in shutdown mode. The correct way to instantiate it it during single threaded start up of the server, where shutdown tasks can be safely registered, and then sharding initialization can simply start up the service.
2) Furthermore it is hitting an invariant in BF-6736, the solution for which is outlined in SERVER-31537

We're just going to remove PeriodicBalancerSettingsRefresher for now, because we don't need it and it is causing problems.



 Comments   
Comment by Githook User [ 18/Oct/17 ]

Author:

{'email': 'dianna.hohensee@10gen.com', 'name': 'Dianna Hohensee', 'username': 'DiannaHohensee'}

Message: SERVER-31585 Remove unused PeriodicBalancerSettingsRefresher

This reverts commit 373e543253801f53dfc881f46f6346c96f43e70d.
Branch: master
https://github.com/mongodb/mongo/commit/548c2e79306912f95a70a348f83d888e2579dcd1

Generated at Thu Feb 08 04:27:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.