[SERVER-31589] A primary's SyncSourceFeedback only renews an OperationContext on role changes. Created: 16/Oct/17  Updated: 30/Oct/23  Resolved: 24/Oct/17

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 3.2.18, 3.4.11, 3.6.0-rc2

Type: Bug Priority: Major - P3
Reporter: Daniel Gottlieb (Inactive) Assignee: Pavithra Vetriselvan
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
related to SERVER-31101 WT table not dropped after collection... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Completed:
Sprint: Repl 2017-10-23, Repl 2017-11-13
Participants:

 Description   

My understanding of the code may be wrong here. The SyncSourceFeedback thread refreshes its OperationContext for each iteration of the outer loop. However, there is an inner while loop that, for primaries, only breaks out when its "position" has changed or if it is no longer a primary. This can cause the OperationContext to not release underlying cursors for indefinitely long periods of time and prevent WT from dropping underlying tables.

https://github.com/mongodb/mongo/blob/649009527527d82711fa1e67e8af66e0d8d4239f/src/mongo/db/repl/sync_source_feedback.cpp#L164-L176



 Comments   
Comment by Githook User [ 17/Nov/17 ]

Author:

{'name': 'Pavithra Vetriselvan', 'email': 'pavithra.vetriselvan@mongodb.com'}

Message: SERVER-31589 Replaces OpContext pts with ReplicationCoordinator ptrs.

(cherry picked from commit 608f38a4fb0de96546dd0aa3eea2f244bbcf2bef)
Branch: v3.2
https://github.com/mongodb/mongo/commit/78a87f7580736c7fbe7ee48d8c7c00716fbc913e

Comment by Githook User [ 17/Nov/17 ]

Author:

{'name': 'Pavithra Vetriselvan', 'email': 'pavithra.vetriselvan@mongodb.com'}

Message: SERVER-31589 Replaces OpContext pts with ReplicationCoordinator ptrs.

(cherry picked from commit 608f38a4fb0de96546dd0aa3eea2f244bbcf2bef)
Branch: v3.4
https://github.com/mongodb/mongo/commit/b7d36fe1669a9752c5ae6e35269ac1bf3d0409c0

Comment by Githook User [ 24/Oct/17 ]

Author:

{'email': 'pavithra.vetriselvan@mongodb.com', 'name': 'Pavithra Vetriselvan'}

Message: SERVER-31589 Replaces OpContext pts with ReplicationCoordinator ptrs.
Branch: master
https://github.com/mongodb/mongo/commit/608f38a4fb0de96546dd0aa3eea2f244bbcf2bef

Comment by Daniel Gottlieb (Inactive) [ 16/Oct/17 ]

spencer Similar to SERVER-31587, it would be sweet to knock this out before 3.6. Let me know if my understanding of this loop is wrong, or the work is otherwise unlikely to be scheduled before 3.6

Generated at Thu Feb 08 04:27:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.