[SERVER-31670] Change replica set fixture used by replica_sets_jscore_passthrough to make its secondary have zero votes Created: 20/Oct/17 Updated: 30/Oct/23 Resolved: 09/Jan/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 3.2.19, 3.4.11, 3.6.3, 3.7.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Spencer Brody (Inactive) | Assignee: | Kevin Albertson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | tig-resmoke | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||||||
| Backport Requested: |
v3.6, v3.4, v3.2
|
||||||||||||||||||||||||||||||||||||
| Sprint: | TIG 2018-1-15 | ||||||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||||||||||||||||||||||
| Description |
|
To prevent unexpected failovers due to machine slowness. We could apply this to any passthrough suites that run against a replica set and expect a stable topology for the duration of the test. This changes the suites meeting the criteria:
Namely, these suites:
|
| Comments |
| Comment by Githook User [ 19/Jan/18 ] | |||||||
|
Author: {'name': 'Kevin Albertson', 'email': 'kevin.albertson@10gen.com', 'username': 'kevinAlbs'}Message: (cherry picked from commit af6bd1d39b42cc3d99c5854c6e280df31e858442) Also includes the following related fix: (cherry picked from commit 60b8011a2f76d14283076a94eac4a9dbec5838bc) | |||||||
| Comment by Spencer Brody (Inactive) [ 13/Jan/18 ] | |||||||
|
kevin.albertson, can you update this ticket's summary/description to make clear what set of suites were actually changed? | |||||||
| Comment by William Schultz (Inactive) [ 12/Jan/18 ] | |||||||
|
max.hirschhorn kevin.albertson Would it be reasonable to make a similar change to the FSM replication suites? | |||||||
| Comment by Githook User [ 11/Jan/18 ] | |||||||
|
Author: {'email': 'kevin.albertson@10gen.com', 'name': 'Kevin Albertson', 'username': 'kevinAlbs'}Message: (cherry picked from commit af6bd1d39b42cc3d99c5854c6e280df31e858442) | |||||||
| Comment by Githook User [ 08/Jan/18 ] | |||||||
|
Author: {'name': 'Kevin Albertson', 'username': 'kevinAlbs', 'email': 'kevin.albertson@10gen.com'}Message: | |||||||
| Comment by Max Hirschhorn [ 27/Dec/17 ] | |||||||
judah.schvimer, while I agree during the test execution itself mongos ought to transparently handle any network errors due to an election, there are a few cases where resmoke.py will have the mongo shell connect directly to the config server replica set. One such case is for performing the data consistency checks. We've previously seen cases where the primary immediately steps down following the "fsyncUnlock" command after the dbhash check finishes (i.e. once stepdown can acquire the global X lock) that I'm inclined to change votes=0 for all replica sets—including the config server replica set—as a way to reduce the number of failures due to an unexpected election. Per our Slack conversation, I also have a possibly more outlandish idea of having passthrough suites that aren't stepping down the CSRS primary use a 1-node replica set as the CSRS, but we'll save that for | |||||||
| Comment by Judah Schvimer [ 27/Dec/17 ] | |||||||
|
Since config servers should be able to handle failover in passthroughs. It might be good to exclude them from this. | |||||||
| Comment by Max Hirschhorn [ 26/Dec/17 ] | |||||||
|
To implement this behavior in resmoke.py, we should be able to just change the default value of voting_secondaries to false when all_nodes_electable=false.
|