[SERVER-31674] Rename misleading functions and structs in cluster_aggregate.cpp Created: 22/Oct/17  Updated: 30/Oct/23  Resolved: 26/Oct/17

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: 3.6.0-rc2

Type: Improvement Priority: Major - P3
Reporter: Bernard Gorman Assignee: Bernard Gorman
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-31597 Refactor $changeStream post-update lo... Closed
Backwards Compatibility: Fully Compatible
Sprint: Query 2017-11-13
Participants:

 Description   
  • The function currently named 'establishShardCursors' is responsible for targeting and splitting/reassembling the pipeline. It does not actually establish any cursors itself; if we are running an aggregation, it delegates to the method currently called 'establishShardCursorsWithoutRetrying', and if we are running an explain then we don't attempt to establish any cursors at all.
  • The struct currently called 'EstablishShardCursorsResults' again may or may not actually contain any cursors on return, but will always contain the results of the pipeline targeting. In fact, the variable that currently stores the returned struct in runAggregate is the much more aptly named 'targetingResults'.

Both of these should be renamed to provide a more accurate description of their purpose.



 Comments   
Comment by Githook User [ 26/Oct/17 ]

Author:

{'email': 'bernard.gorman@gmail.com', 'name': 'Bernard Gorman', 'username': 'gormanb'}

Message: SERVER-31674 Rename misleading functions and structs in cluster_aggregate.cpp
Branch: master
https://github.com/mongodb/mongo/commit/253d4c559450238d786e03d3c3118f02e6b9358f

Generated at Thu Feb 08 04:27:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.