[SERVER-31806] makeNoopWriter crashes when the last applied optime advances in the face of failed appendOplogNotes. Created: 02/Nov/17 Updated: 30/Oct/23 Resolved: 14/Nov/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 3.6.0-rc4, 3.7.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Daniel Gottlieb (Inactive) | Assignee: | Misha Tyulenev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Sprint: | Sharding 2017-11-13, Sharding 2017-12-04 | ||||||||||||
| Participants: | |||||||||||||
| Linked BF Score: | 0 | ||||||||||||
| Description |
|
I believe this is 3.6 required. makeNoopWriteIfNeeded (in read_concern.cpp) will ensure an oplog document exists on the primary with at least the clusterTime. This guarantees the secondary will eventually apply up to the requested clusterTime. This method can succeed in two(ish) cases.
The method initializes a return status of OK. Some error cases will immediately return an error code, such as not finding the correct shard, or the number of retries to make the request has been exceeded. Otherwise status is assigned the latest result of the request. However, when a request fails, leaving status in an error state, the lastAppliedOpTime is refreshed. If this new value exceeds the requested clusterTime, the loop will exit, but the code invariants that the status is ok. |
| Comments |
| Comment by Githook User [ 14/Nov/17 ] |
|
Author: {'name': 'Misha Tyulenev', 'username': 'mikety', 'email': 'misha@mongodb.com'}Message: (cherry picked from commit f6d08a2e38cd27bd0e9a841a6ffc112ce0298d0f) |
| Comment by Githook User [ 14/Nov/17 ] |
|
Author: {'name': 'Misha Tyulenev', 'username': 'mikety', 'email': 'misha@mongodb.com'}Message: |