[SERVER-31865] setFCV on config server should only generate UUIDs for non-dropped sharded collections Created: 07/Nov/17 Updated: 30/Oct/23 Resolved: 30/Nov/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | 3.6.0-rc2 |
| Fix Version/s: | 3.6.1, 3.7.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Esha Maharishi (Inactive) | Assignee: | Esha Maharishi (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||||||||||
| Backport Requested: |
v3.6
|
||||||||||||||||||||||||||||
| Steps To Reproduce: |
|
||||||||||||||||||||||||||||
| Sprint: | Sharding 2017-12-04 | ||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||||||||||||||
| Description |
|
It may not cause any incorrect behavior (that I know of), but it's weird... we should make the write to mark the collection entry as 'dropped' use $set rather than a replacement-style update. Example collection entry after shardCollection (produced using the attached repro):
How that collection entry looks after drop:
It also looks like dropCollection clears the lastmodEpoch (i.e., epoch); I don't see why it should do this? |
| Comments |
| Comment by Githook User [ 05/Dec/17 ] |
|
Author: {'username': 'EshaMaharishi', 'email': 'esha.maharishi@mongodb.com', 'name': 'Esha Maharishi'}Message: (cherry picked from commit 0fd5cb5718f511f42a8c6622285d97648e9a3fa0) |
| Comment by Githook User [ 30/Nov/17 ] |
|
Author: {'name': 'Esha Maharishi', 'username': 'EshaMaharishi', 'email': 'esha.maharishi@mongodb.com'}Message: |
| Comment by Kaloian Manassiev [ 10/Nov/17 ] |
|
Instead of doing this, we should fix the setFCV query for collection discovery. |
| Comment by Esha Maharishi (Inactive) [ 07/Nov/17 ] |
|
It's also odd because a UUID gets (re)generated for these dropped collections on setFCV. We should also make the query that setFCV uses to find collections that need UUIDs exclude dropped collections. |
| Comment by Esha Maharishi (Inactive) [ 07/Nov/17 ] |
|
Noticed while investigating BF-6349. |