[SERVER-32041] amend stableCandidates logic from replcoord Created: 20/Nov/17  Updated: 30/Oct/23  Resolved: 22/Nov/17

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 3.6.0-rc6, 3.7.1

Type: Task Priority: Major - P3
Reporter: Eric Milkie Assignee: Eric Milkie
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File las-ttl.png    
Issue Links:
Backports
Depends
Related
related to SERVER-30577 Clear list of stable timestamp candid... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v3.6
Sprint: Storage 2017-12-04
Participants:
Linked BF Score: 0

 Description   

Changing the stableCandidates logic to avoid needing a candidate for every primary write will result in a performance boost.



 Comments   
Comment by Githook User [ 27/Nov/17 ]

Author:

{'name': 'Eric Milkie', 'username': 'milkie', 'email': 'milkie@10gen.com'}

Message: SERVER-32041 missed a file when cherry-picking
Branch: v3.6
https://github.com/mongodb/mongo/commit/1d7d84599ac6a55dac3aec3eba80160a9f4deb1f

Comment by Githook User [ 27/Nov/17 ]

Author:

{'name': 'Eric Milkie', 'username': 'milkie', 'email': 'milkie@10gen.com'}

Message: SERVER-32041 more efficient logic in setMyLastAppliedOpTime

Attempt at making setMyLastAppliedOpTime faster, when triggered by a write on a primary node.
In addition, be more careful to move the oldest_timestamp forward on one-node replica sets, regardless
of workload.

(cherry picked from commit 17dfc88333df0be6bb7711efb1885a21a3a697b9)
Branch: v3.6
https://github.com/mongodb/mongo/commit/093fadbf7ee759b7f8a8f45642c520095b0047d6

Comment by Githook User [ 22/Nov/17 ]

Author:

{'name': 'Eric Milkie', 'username': 'milkie', 'email': 'milkie@10gen.com'}

Message: SERVER-32041 more efficient logic in setMyLastAppliedOpTime

Attempt at making setMyLastAppliedOpTime faster, when triggered by a write on a primary node.
In addition, be more careful to move the oldest_timestamp forward on one-node replica sets, regardless
of workload.
Branch: master
https://github.com/mongodb/mongo/commit/17dfc88333df0be6bb7711efb1885a21a3a697b9

Comment by Susan LoVerso [ 21/Nov/17 ]

milkie Here are some FTDC stats from a run with your changes compared to mongodb master (with current WT develop). I ran the TTL workload three times for three minutes each time. Your change results in a 50% degradation compared to master. Your changes definitely cause a lot more LAS activity compared to mongodb master. In this chart, the run with your changes is on the left and mongodb master is on the right.

Generated at Thu Feb 08 04:29:00 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.