[SERVER-32134] Refactor "run tests" disable_unit_tests condition in evergreen.yml Created: 01/Dec/17  Updated: 27/Sep/18  Resolved: 27/Sep/18

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Minor - P4
Reporter: Jonathan Abrahams Assignee: DO NOT USE - Backlog - Test Infrastructure Group (TIG)
Resolution: Won't Fix Votes: 0
Labels: close, neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Participants:

 Description   

The disable_unit_tests conditional test in "run tests" is hard to follow as there is no indentation and the entire function is ignored if it's set to true.

Suggest changing the code block:

        if [ ${disable_unit_tests|false} = "false" ]; then
 
        # activate the virtualenv if it has been set up
        ${activate_virtualenv}
 
        if [ -f /proc/self/coredump_filter ]; then
          # Set the shell process (and its children processes) to dump ELF headers (bit 4),
...
        fi # end if ${disable_unit_tests}

Should be refactored to

        if [ ${disable_unit_tests|false} = "true" ]; then
          exit 0
        fi
 
        # activate the virtualenv if it has been set up
        ${activate_virtualenv}
 
        if [ -f /proc/self/coredump_filter ]; then
...


Generated at Thu Feb 08 04:29:17 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.