[SERVER-32281] Thread pool task executor ignores errors returned from startCommand() Created: 12/Dec/17 Updated: 30/Oct/23 Resolved: 17/Aug/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Networking |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.2, 4.1.3 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Samantha Ritter (Inactive) | Assignee: | Benjamin Caimano (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | ASE, ASIO, neweng, service_architecture | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | Platforms 2017-12-18, Platforms 2018-01-01, Platforms 2018-01-15 |
| Participants: |
| Description |
|
If NetworkInterfaceASIO is in shutdown, it will return an error from startCommand(). The ThreadPoolTaskExecutor ignores such errors. This could possibly lead to hangs, if a calling thread starts a command after shutdown has been called, because NetworkInterfaceASIO will never do that work or call its callback. |
| Comments |
| Comment by Githook User [ 16/Aug/18 ] |
|
Author: {'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}Message: (cherry picked from commit f5d598dbc6b0eb1340d84d7d2c6faf0fd249a74b) |
| Comment by Andy Schwerin [ 13/Dec/17 ] |
|
I think it used to be a programming error to shut the network interface down before the task executor, making this bug less of an issue. What are the shutdown rules now? |