[SERVER-32332] Put SyncTail behind new Applier interface Created: 14/Dec/17  Updated: 30/Oct/23  Resolved: 23/Mar/18

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 3.7.4

Type: Task Priority: Major - P3
Reporter: Gregory McKeon (Inactive) Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-32354 Create new OplogApplier interface Closed
is depended on by SERVER-32333 Update steady state replication to us... Closed
is depended on by SERVER-32334 Update startup/rollback recovery to u... Closed
is depended on by SERVER-32335 Update initial sync to use new Applie... Closed
is depended on by SERVER-32336 Update applyOps to use new Applier in... Closed
is depended on by SERVER-32339 Update doTxn to use new Applier inter... Closed
Related
related to SERVER-39950 Merge two oplog batching code paths Closed
related to SERVER-33864 Remove OplogApplier::Observer::onOper... Closed
is related to SERVER-26772 Remove old initial sync code Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2018-03-12, Repl 2018-03-26
Participants:

 Comments   
Comment by Githook User [ 23/Mar/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-32332 remove RSDataSync
Branch: master
https://github.com/mongodb/mongo/commit/a4ca57ddbf4572a5b2c5f1e6dbbb4cb01deea7a2

Comment by Githook User [ 23/Mar/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-32332 replace RSDataSync in ReplicationCoordinatorExternalStateImpl with OplogApplier
Branch: master
https://github.com/mongodb/mongo/commit/01aec10a8c9e296252e399f1d0bf9dd859a39a7f

Comment by Githook User [ 23/Mar/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-32332 add dedicated task executor for OplogApplier
Branch: master
https://github.com/mongodb/mongo/commit/bb82aba999a3fdbe81a26d636d6346ae2c3a2be9

Comment by Githook User [ 23/Mar/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-32332 implement OplogApplier for steady state replication
Branch: master
https://github.com/mongodb/mongo/commit/ecd44a0d4e7ef134ab9ec0236e1d5fa8ab4e59b0

Comment by Githook User [ 23/Mar/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-32332 grant internal authorization to threads created for repl task executor
Branch: master
https://github.com/mongodb/mongo/commit/e0f8ca9a3f8201c27dffcdf4014f2b2d95bbd869

Comment by Githook User [ 23/Mar/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-32332 move mmapv1 prefetch override from RSDataSync to SyncTail::oplogApplication()
Branch: master
https://github.com/mongodb/mongo/commit/fa11d0939a156c215d556571df8c6409bd2a7d7e

Comment by Githook User [ 13/Mar/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-32332 decouple BackgroundSync from SyncTail

Explicit shutdown() functions for SyncTail and RSDataSync.
BackgroundSync implements OplogApplier::Observer.
OplogBuffer for steady state replication is now cleared in
ReplicationCoordinatorExternalStateImpl::shutdown() between shutting down
and joining BackgroundSync/SyncTail.
Branch: master
https://github.com/mongodb/mongo/commit/d988a58bcb09d45a841570e26e7d50a4e9c23de8

Comment by Githook User [ 12/Mar/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-32332 move ownership of OplogBuffer from BackgroundSync to ReplicationCoordinatorExternalStateImpl

The new OplogApplier requires an OplogBuffer passed in at construction.
Moving the ownership out of BackgroundSync makes it clear that the OplogBuffer
is owned by neither BackgroundSync nor OplogApplier.
Branch: master
https://github.com/mongodb/mongo/commit/a1942a4ea0d79aaa7bb93978acbc4273af29a2eb

Comment by Githook User [ 12/Mar/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-32332 remove makeSteadyStateOplogBuffer() from ReplicationCoordinatorExternalState and DataReplicatorExternalState interfaces
Branch: master
https://github.com/mongodb/mongo/commit/945167575f86cb4fba7c239cdd4264d2da30d4dc

Comment by Githook User [ 12/Mar/18 ]

Author:

{'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}

Message: SERVER-32332 remove unused function BackgroundSync::pushTestOpToBuffer()

The last caller of this function was removed in commit f53a88a57da5788b355cb3037061372a706ccf0d.
Branch: master
https://github.com/mongodb/mongo/commit/d7a3277821c6ae512efd7168cea07f6390c844d6

Generated at Thu Feb 08 04:29:55 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.