[SERVER-32348] Make UpdateDriver::parse() throw an exception instead of returning error Status Created: 14/Dec/17 Updated: 30/Oct/23 Resolved: 29/Jun/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.1 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Justin Seyster | Assignee: | Minji Kim |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Query 2018-06-18, Query 2018-07-02, Query 2018-07-16 |
| Participants: |
| Description |
|
Currently, UpdateDriver::parse() has a Status return type and can return an error Status, but it can also propagate exceptions from UpdateDriver::parseUpdateExpression(). Because we are moving towards exception throwing for indicating errors, we should modify UpdateDriver::parse() so that it returns void and uasserts at places where it currently returns an error. As far as we know, UpdateDriver::parse() call sites behave correctly in cases where exceptions are thrown, but we should probably audit them anyway when making this change. |
| Comments |
| Comment by Githook User [ 29/Jun/18 ] |
|
Author: {'username': 'minjikim0202', 'name': 'Minji', 'email': 'minjikim0202@gmail.com'}Message: |