[SERVER-32353] Inequality check in update_affects_indexes.js can erroneously succeed Created: 14/Dec/17  Updated: 30/Oct/23  Resolved: 15/Dec/17

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: 3.2.19, 3.4.11, 3.6.1, 3.7.1
Fix Version/s: 3.7.1

Type: Bug Priority: Major - P3
Reporter: Tess Avitabile (Inactive) Assignee: Tess Avitabile (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-32393 assert.neq() does shallow inequality ... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Query 2018-01-01
Participants:

 Description   

This inequality check in update_affect_indexes.js will always succeed, even if the objects being compared are in fact equal.



 Comments   
Comment by Githook User [ 15/Dec/17 ]

Author:

{'name': 'Tess Avitabile', 'email': 'tess.avitabile@mongodb.com', 'username': 'tessavitabile'}

Message: SERVER-32353 Do not use neq to compare documents in update_affects_indexes.js
Branch: master
https://github.com/mongodb/mongo/commit/b1ae796faf5f262cd658f59a59d18f8c3eb0d4ee

Comment by Tess Avitabile (Inactive) [ 14/Dec/17 ]

The test still passes if the assert.neq(...) is changed to an assert(!friendlyEqual(...)), so the behavior of the server is still as expected. This is also not the most important aspect of the test, since this part is checking that the index key does not exist yet, so we can confirm it is created later. So this ticket is likely low priority. I will fix this issue for the 3.0 backport.

Generated at Thu Feb 08 04:29:59 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.