[SERVER-32361] Rollback tests that expect a fatal assertion after node restart should not wait for connection Created: 15/Dec/17 Updated: 30/Oct/23 Resolved: 12/Jan/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 3.6.3, 3.7.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | William Schultz (Inactive) | Assignee: | William Schultz (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | bkp | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Backport Requested: |
v3.6
|
||||||||||||
| Sprint: | Repl 2018-01-01 | ||||||||||||
| Participants: | |||||||||||||
| Linked BF Score: | 0 | ||||||||||||
| Description |
|
There are a number of tests (rollback_too_new.js, rollback_collMod_fatal.js, rollback_cmd_unrollbackable.js) that will try to induce a rollback that causes a node to fassert. Most of them will, at the end of the test, restart a node that they expect to then go into rollback and fassert. Whenever we start up a node in a JS test again, we can optionally wait for a connection to it. For a node being restarted that we expect to immediately fassert, though, this "wait for connection" behavior is inherently flaky, since we have no way of controlling how quickly the node will start up and then crash. So if we try to connect after the crash has already occurred, the test will fail since it wasn't able to connect to the node. We can fix this issue by simply not waiting for a node connection if it is not necessary. For a node that we expect to fassert right after startup, we shouldn't need to re-connect to it. |
| Comments |
| Comment by Githook User [ 29/Jan/18 ] |
|
Author: {'email': 'william.schultz@mongodb.com', 'name': 'William Schultz', 'username': 'will62794'}Message: (cherry picked from commit d8d2f422d0f072f30a08bd4b1bfc567be0899ce7) |
| Comment by Githook User [ 19/Dec/17 ] |
|
Author: {'name': 'William Schultz', 'email': 'william.schultz@mongodb.com', 'username': 'will62794'}Message: |