[SERVER-32604] prevent adding a binary last-stable shard if the cluster is upgrading or downgrading Created: 09/Jan/18  Updated: 30/Oct/23  Resolved: 23/Feb/18

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 3.6.4

Type: Bug Priority: Major - P3
Reporter: Dianna Hohensee (Inactive) Assignee: Esha Maharishi (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Sharding 2018-02-26
Participants:

 Description   

This only needs to go into v3.6, because v3.8 will remove the addShard FCV & WireVersion check courtesy of changes to be done in SERVER-32519

We bump the wire version (here) if we're fully upgraded, upgrading or downgrading. However, in addShard (here) we only prevent adding the shard if we're fully upgraded.

So, currently, if we're in the process of upgrading, we'll allow an old binary version shard to be added, and then we'll presumable finish upgrading and no server will talk to it ever again.



 Comments   
Comment by Esha Maharishi (Inactive) [ 23/Feb/18 ]

dianna.hohensee sure, I filed SERVER-33465. Can you review it?

Comment by Dianna Hohensee (Inactive) [ 23/Feb/18 ]

esha.maharishi, do we want the setFCV change part, to distinguish upgrading/downgrading, in v4.0 as well?

Comment by Githook User [ 23/Feb/18 ]

Author:

{'email': 'esha.maharishi@mongodb.com', 'name': 'Esha Maharishi', 'username': 'EshaMaharishi'}

Message: SERVER-32604 prevent adding a binary last-stable shard if the cluster is upgrading or downgrading
Branch: v3.6
https://github.com/mongodb/mongo/commit/e1cc0fb45f6b5bbe596158258122d188667a43fe

Generated at Thu Feb 08 04:30:44 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.