[SERVER-32624] dropDatabase() should wait for collection drops using ReplicationCoordinator::awaitReplication() instead of awaitReplicationOfLastOpForClient() Created: 09/Jan/18 Updated: 30/Oct/23 Resolved: 10/Jan/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 3.6.3, 3.7.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Benety Goh | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Operating System: | ALL | ||||||||||||||||
| Participants: | |||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||
| Description |
|
dropDatabase currently uses both ReplicationCoordinator::awaitReplication() and awaitReplicationOfLastOpForClient() when waiting for collection drops to complete depending the state of the collections in the database at command invocation. We should be unifying these two code paths and use awaitReplication() with an explicit optime. awaitReplicationOfLastOpForClient() also has the unnecessary effect of waiting for the current snapshot which is not necessary for dropDatabase because we are only interested in waiting for the drop pending collection reaper, which is triggered by the commit optime advancing, to complete its work. |
| Comments |
| Comment by Githook User [ 11/Jan/18 ] |
|
Author: {'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}Message: (cherry picked from commit ba1d0d901ef386310457b03eecf9f5c4afce9047) |
| Comment by Githook User [ 11/Jan/18 ] |
|
Author: {'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}Message: (cherry picked from commit 256dcb71d9b2f0110bc65b377f30f9ab4b24ef83) |
| Comment by Githook User [ 10/Jan/18 ] |
|
Author: {'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}Message: |
| Comment by Githook User [ 10/Jan/18 ] |
|
Author: {'email': 'benety@mongodb.com', 'name': 'Benety Goh', 'username': 'benety'}Message: |