[SERVER-32778] Fix perf regression on shell assertions changes Created: 18/Jan/18  Updated: 30/Oct/23  Resolved: 22/Jan/18

Status: Closed
Project: Core Server
Component/s: Shell, Testing Infrastructure
Affects Version/s: None
Fix Version/s: 3.7.2

Type: Bug Priority: Major - P3
Reporter: Kevin Albertson Assignee: Kevin Albertson
Resolution: Fixed Votes: 0
Labels: prf
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Problem/Incident
is caused by SERVER-31335 Shell needs an "assert failed with co... Closed
Related
related to SERVER-33034 Change assertion functions to accept ... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:
Linked BF Score: 0

 Description   

SERVER-31335 introduced a perf regression on assert.commandWorked, assert.commandFailed, and assert.commandFailedWithCode now always json stringify the response regardless of whether or not the assert needs the message. This surfaced in change streams perf tests.



 Comments   
Comment by Githook User [ 19/Jan/18 ]

Author:

{'name': 'Kevin Albertson', 'email': 'kevin.albertson@10gen.com', 'username': 'kevinAlbs'}

Message: SERVER-32778 do not eagerly tojson in shell assertions
Branch: master
https://github.com/mongodb/mongo/commit/71ae3ed5b7e99ddb629ec64b85f4bd75b73aff17

Generated at Thu Feb 08 04:31:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.