[SERVER-32819] Tests in jstests/aggregation/variables/ directory aren't running in aggregation passthroughs Created: 21/Jan/18  Updated: 30/Oct/23  Resolved: 08/Feb/18

Status: Closed
Project: Core Server
Component/s: Aggregation Framework, Testing Infrastructure
Affects Version/s: 3.6.0
Fix Version/s: 3.7.2

Type: Bug Priority: Major - P3
Reporter: Max Hirschhorn Assignee: Charlie Swanson
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
is caused by SERVER-27614 provide aggregation expression to rem... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Query 2018-02-12
Participants:

 Description   

The jstests/aggregation/variables/ directory was introduced in 2f367a1 as part of SERVER-27614. However, the jstests/aggregation/variables/ directory was only added to the "roots" section of the aggregation.yml test suite. This means these tests aren't running in the following test suites:

  • aggregation_auth.yml
  • aggregation_ese.yml
  • aggregation_facet_unwind_passthrough.yml
  • aggregation_read_concern_majority_passthrough.yml
  • aggregation_sharded_collections_passthrough.yml

I think we should change the "roots" section to jstests/aggregation/**/*.js and specifically exclude the jstests/aggregation/data/ and jstests/aggregation/extras/ directories in order to avoid this kind of situation in the future.



 Comments   
Comment by Githook User [ 08/Feb/18 ]

Author:

{'email': 'charlie.swanson@mongodb.com', 'name': 'Charlie Swanson', 'username': 'cswanson310'}

Message: SERVER-32819 Default to include all subdirectories in agg passthroughs
Branch: master
https://github.com/mongodb/mongo/commit/59ccc36dc19faa062f1f2655a10ad7f70ec79cb0

Comment by David Storch [ 29/Jan/18 ]

charlie.swanson Yep, sounds good to me.

Comment by Charlie Swanson [ 23/Jan/18 ]

david.storch looks like you're out Friday so we might miss triage. I'm already planning on doing SERVER-32668 and SERVER-32667 next sprint. Mind if I take this one as well for next sprint? Max's suggestion of switching from whitelist to blacklist sounds reasonable to me and should be a quick fix.

Generated at Thu Feb 08 04:31:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.