[SERVER-3285] Dead Assignment/Variable added in commit 884e100 (also a NULL dereference bug) Created: 17/Jun/11 Updated: 12/Jul/16 Resolved: 23/Jun/11 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 1.9.1 |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Chris Wilson | Assignee: | Kristina Chodorow (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Operating System: | ALL |
| Participants: |
| Description |
|
Hi, We are using Sentry (a C/C++ static analysis tool) to analyze While reviewing that issue, I also noticed a potential NULL I've provided a patch for each issue. I can see from the code that the dead assignment was at one point a The NULL dereference could be a potentially serious bug if targetHost can be NULL I'm not sure either of these patches are the correct patch considering I don't know Thanks, – |
| Comments |
| Comment by Kristina Chodorow (Inactive) [ 23/Jun/11 ] |
|
Thanks, merged! |
| Comment by auto [ 23/Jun/11 ] |
|
Author: {u'login': u'kchodorow', u'name': u'Kristina', u'email': u'kristina@10gen.com'}Message: fix null deref Patch by Mike Mueller |
| Comment by Mike Mueller [ 23/Jun/11 ] |
|
Hi Kristina, I've gone ahead and signed the agreement on behalf of Vigilant. Thanks! |
| Comment by Kristina Chodorow (Inactive) [ 20/Jun/11 ] |
|
Thanks for the patches! Can you sign the contributor's agreement so that I can merge in the null dereference one? http://10gen-corp.appspot.com/contributor |
| Comment by Chris Wilson [ 18/Jun/11 ] |
|
Looks like the dead assign was updated in this patch, Please still look at the null dereference issue. |