[SERVER-32854] Create implementation for ReplicationCoordinator for embedded Created: 23/Jan/18  Updated: 30/Oct/23  Resolved: 01/Feb/18

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 3.7.2

Type: Task Priority: Major - P3
Reporter: Henrik Edin Assignee: Henrik Edin
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-32860 Depend on repl_coordinator_interface ... Closed
Backwards Compatibility: Fully Compatible
Sprint: Platforms 2018-01-29, Platforms 2018-02-12
Participants:

 Description   

It should report replication disabled and not allow it to be started. Should reduce dependencies on embedded.



 Comments   
Comment by Githook User [ 01/Feb/18 ]

Author:

{'email': 'henrik.edin@mongodb.com', 'name': 'Henrik Edin', 'username': 'henrikedin'}

Message: SERVER-32854 Replication Coordinator implementation for embedded. It implements a subset of the interface reporting replication disabled. Uasserts when attempting to perform any replication logic.
Branch: master
https://github.com/mongodb/mongo/commit/b1a3d36f48369fb0dacd5e8dde7439f586e2f6f9

Comment by Henrik Edin [ 26/Jan/18 ]

I'm adding a new implementation to this interface, I don't expect a need to do any actual changes to the interface itself. The idea is to provide mock implementations for the methods we need it for (isReplEnabled etc). The part of the interface that require replication to be enabled will just uassert or invariant. You could use that distinction as a basis to at least split this up in two. One minimal to check replication status and one to perform replication actions.

Comment by Andy Schwerin [ 24/Jan/18 ]

spencer , this might provide good motivation to start breaking the Repl Coordinator into more types. If every time we edit the interface of the coordinates we have to touch this type as well as the mock, we'll be changing 4 types spread across maybe 8 files.

Generated at Thu Feb 08 04:31:29 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.