[SERVER-32907] Turn heartbeat log verbosity back down in tests Created: 25/Jan/18  Updated: 30/Oct/23  Resolved: 09/Jul/18

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 3.6.7, 4.0.2, 4.1.1

Type: Task Priority: Major - P3
Reporter: Spencer Brody (Inactive) Assignee: William Schultz (Inactive)
Resolution: Fixed Votes: 5
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
related to SERVER-32906 Improve logging around elections Closed
related to SERVER-27908 log every heartbeat during testing Closed
is related to SERVER-36357 Add ability to express different log ... Open
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.0, v3.6, v3.4
Sprint: Repl 2018-06-18, Repl 2018-07-02, Repl 2018-07-16
Participants:

 Description   

In SERVER-27908 we increased the logging around heartbeats, but it isn't clear that we gained much from it, and it adds a lot of noise to log files. We believe that the most interesting times for these log messages are around when elections are happening, so we think that after doing SERVER-32906 the need for high verbosity heartbeat logs goes down.



 Comments   
Comment by Githook User [ 13/Aug/18 ]

Author:

{'name': 'William Schultz', 'email': 'william.schultz@mongodb.com', 'username': 'will62794'}

Message: SERVER-32907 Reduce replication.heartbeat log verbosity in local test logs

This patch creates separate 'logComponentVerbosity' default settings
for tests running running locally versus those running in
Evergreen. This only applies to tests run using resmoke.py. We detect
that a test is running in Evergreen by checking if resmoke received
an EVERGREEN_TASK_ID parameter.

(cherry picked from commit 4c725a11acf11e41e8200500a03d3cec97a25dbe)
Branch: v4.0
https://github.com/mongodb/mongo/commit/5b523ccf4a5df3021dc025a05853879fda05cd0a

Comment by Githook User [ 13/Aug/18 ]

Author:

{'name': 'William Schultz', 'email': 'william.schultz@mongodb.com', 'username': 'will62794'}

Message: SERVER-32907 Make resmoke pass TestData.setParameters to mongo shell as a JavaScript object

This patch changes the format of the TestData.setParameters variable we
pass to the mongo shell from within resmoke. We now pass this value as a
JavaScript object, where keys are parameter names and values are the
values to set for that parameter. Additionally, we also consolidate the
hard-coded 'logComponentVerbosity' default settings into resmoke, instead of
having them mixed between servers.js and resmoke's programs.py. Now, any
mongod processes started either directly by resmoke or via a mongo shell
that was started by resmoke will receive default log verbosity settings
from a value defined in resmoke.

(cherry picked from commit 5b2739dbff77811dbbfbccbc8a7ca8b973c8525f)
Branch: v4.0
https://github.com/mongodb/mongo/commit/9b975539a9c715a34dc478a8a947f82789a15b53

Comment by Githook User [ 24/Jul/18 ]

Author:

{'name': 'William Schultz', 'email': 'william.schultz@mongodb.com', 'username': 'will62794'}

Message: SERVER-32907 Reduce replication.heartbeat log verbosity in local test logs

This patch creates separate 'logComponentVerbosity' default settings
for tests running running locally versus those running in
Evergreen. This only applies to tests run using resmoke.py. We detect
that a test is running in Evergreen by checking if resmoke received
an EVERGREEN_TASK_ID parameter.

(cherry picked from commit 4c725a11acf11e41e8200500a03d3cec97a25dbe)
Branch: v3.6
https://github.com/mongodb/mongo/commit/d4ee1bbc53d24474432ae05658ed35b9655b5e37

Comment by Githook User [ 24/Jul/18 ]

Author:

{'name': 'William Schultz', 'email': 'william.schultz@mongodb.com', 'username': 'will62794'}

Message: SERVER-32907 Make resmoke pass TestData.setParameters to mongo shell as a JavaScript object

This patch changes the format of the TestData.setParameters variable we
pass to the mongo shell from within resmoke. We now pass this value as a
JavaScript object, where keys are parameter names and values are the
values to set for that parameter. Additionally, we also consolidate the
hard-coded 'logComponentVerbosity' default settings into resmoke, instead of
having them mixed between servers.js and resmoke's programs.py. Now, any
mongod processes started either directly by resmoke or via a mongo shell
that was started by resmoke will receive default log verbosity settings
from a value defined in resmoke.

(cherry picked from commit 5b2739dbff77811dbbfbccbc8a7ca8b973c8525f)
Branch: v3.6
https://github.com/mongodb/mongo/commit/8d5057bbe9e75d6c1081ed63c35e330434a12268

Comment by Githook User [ 09/Jul/18 ]

Author:

{'username': 'will62794', 'name': 'William Schultz', 'email': 'william.schultz@mongodb.com'}

Message: SERVER-32907 Reduce replication.heartbeat log verbosity in local test logs

This patch creates separate 'logComponentVerbosity' default settings
for tests running running locally versus those running in
Evergreen. This only applies to tests run using resmoke.py. We detect
that a test is running in Evergreen by checking if resmoke received
an EVERGREEN_TASK_ID parameter.
Branch: master
https://github.com/mongodb/mongo/commit/4c725a11acf11e41e8200500a03d3cec97a25dbe

Comment by Githook User [ 06/Jul/18 ]

Author:

{'username': 'will62794', 'name': 'William Schultz', 'email': 'william.schultz@mongodb.com'}

Message: SERVER-32907 Make resmoke pass TestData.setParameters to mongo shell as a JavaScript object

This patch changes the format of the TestData.setParameters variable we
pass to the mongo shell from within resmoke. We now pass this value as a
JavaScript object, where keys are parameter names and values are the
values to set for that parameter. Additionally, we also consolidate the
hard-coded 'logComponentVerbosity' default settings into resmoke, instead of
having them mixed between servers.js and resmoke's programs.py. Now, any
mongod processes started either directly by resmoke or via a mongo shell
that was started by resmoke will receive default log verbosity settings
from a value defined in resmoke.
Branch: master
https://github.com/mongodb/mongo/commit/5b2739dbff77811dbbfbccbc8a7ca8b973c8525f

Comment by Gregory McKeon (Inactive) [ 06/Mar/18 ]

We likely want to do this by setting the default log verbosity to be lower, and using the evergreen configuration variables to turn verbosity back up.

This means that the logs in EVG will be unchanged but local logs through resmoke.py should be less verbose.

Comment by Kaloian Manassiev [ 28/Feb/18 ]

I have the same problem. Especially for sharding it is a major nuisance running tests locally because of the 3 config servers, which make using the same shell impossible.

Comment by Eric Milkie [ 28/Feb/18 ]

They are still getting in the way for me, and I'm not using lobster because I am running tests locally on my machine as part of normal development. Currently, I must remember to disable them by hand by hacking servers.js, and then be extra careful not to push the change to master.

Generated at Thu Feb 08 04:31:40 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.