[SERVER-32935] improve exception handling in SyncTail::oplogApplication() Created: 26/Jan/18 Updated: 29/Oct/23 Resolved: 05/Jun/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | 3.4.10, 3.6.2, 3.7.1 |
| Fix Version/s: | 3.4.16, 3.6.6, 4.0.0, 4.1.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Benety Goh | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | replApplier | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||||||
| Backport Requested: |
v4.0
|
||||||||||||||||||||||||
| Sprint: | Repl 2018-05-21, Repl 2018-06-04, Repl 2018-06-18 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Linked BF Score: | 50 | ||||||||||||||||||||||||
| Description |
|
unexpected exceptions in SyncTail;:oplogApplication may sometimes cause OpQueueBatcher to terminate early and trigger the invariant on the _isDead field. We should consider more graceful shutdown semantics for the OpQueueBatcher or handle exceptions in oplogApplication() explicitly. This issue affects 3.4 through 3.6 |
| Comments |
| Comment by Githook User [ 26/Feb/20 ] |
|
Author: {'name': 'Siyuan Zhou', 'username': 'visualzhou', 'email': 'siyuan.zhou@mongodb.com'}Message: Reverted a5cbd93aea (cherry picked from commit 89a6d7bc3a0126cf8bfd177ad65b233181641175) |
| Comment by Githook User [ 05/Sep/19 ] |
|
Author: {'username': 'visualzhou', 'email': 'siyuan.zhou@mongodb.com', 'name': 'Siyuan Zhou'}Message: Reverted a5cbd93aea (cherry picked from commit 89a6d7bc3a0126cf8bfd177ad65b233181641175) |
| Comment by Githook User [ 23/Aug/19 ] |
|
Author: {'username': 'visualzhou', 'email': 'siyuan.zhou@mongodb.com', 'name': 'Siyuan Zhou'}Message: Reverted a5cbd93aea |
| Comment by Githook User [ 08/Jun/18 ] |
|
Author: {'username': 'benety', 'name': 'Benety Goh', 'email': 'benety@mongodb.com'}Message: This change uses the terminate handler to log unexpected exceptions thrown (cherry picked from commit 09ea5600193cee30260c4d0a114f6464b870ab84) |
| Comment by Githook User [ 08/Jun/18 ] |
|
Author: {'username': 'benety', 'name': 'Benety Goh', 'email': 'benety@mongodb.com'}Message: (cherry picked from commit a5cbd93aeaa7de9857b82396888a91ef488c9c7c) |
| Comment by Githook User [ 07/Jun/18 ] |
|
Author: {'username': 'benety', 'name': 'Benety Goh', 'email': 'benety@mongodb.com'}Message: This change uses the terminate handler to log unexpected exceptions thrown (cherry picked from commit 09ea5600193cee30260c4d0a114f6464b870ab84) |
| Comment by Githook User [ 07/Jun/18 ] |
|
Author: {'username': 'benety', 'name': 'Benety Goh', 'email': 'benety@mongodb.com'}Message: (cherry picked from commit a5cbd93aeaa7de9857b82396888a91ef488c9c7c) |
| Comment by Githook User [ 07/Jun/18 ] |
|
Author: {'username': 'benety', 'name': 'Benety Goh', 'email': 'benety@mongodb.com'}Message: This change uses the terminate handler to log unexpected exceptions thrown (cherry picked from commit 09ea5600193cee30260c4d0a114f6464b870ab84) |
| Comment by Githook User [ 07/Jun/18 ] |
|
Author: {'username': 'benety', 'name': 'Benety Goh', 'email': 'benety@mongodb.com'}Message: (cherry picked from commit a5cbd93aeaa7de9857b82396888a91ef488c9c7c) |
| Comment by Githook User [ 05/Jun/18 ] |
|
Author: {'username': 'benety', 'name': 'Benety Goh', 'email': 'benety@mongodb.com'}Message: This change uses the terminate handler to log unexpected exceptions thrown |
| Comment by Githook User [ 05/Jun/18 ] |
|
Author: {'username': 'benety', 'name': 'Benety Goh', 'email': 'benety@mongodb.com'}Message: |
| Comment by Spencer Brody (Inactive) [ 03/May/18 ] |
|
william.schultz, check in with benety.goh about what the best thing to do here is. |
| Comment by Spencer Brody (Inactive) [ 08/Feb/18 ] |
|
This is mainly about better logging around exception context to aid debugging. |