[SERVER-32955] Ensure Benchmark compiles with icecream Created: 29/Jan/18  Updated: 27/Apr/18  Resolved: 07/Mar/18

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: 3.7.1
Fix Version/s: 3.6.5

Type: Task Priority: Major - P3
Reporter: Robert Guo (Inactive) Assignee: Robert Guo (Inactive)
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Duplicate
duplicates SERVER-33491 Fix benchmark.h compile with -fdirect... Closed
Related
related to SERVER-32785 Integrate Google Benchmark into SCons Closed
Backport Requested:
v3.6
Sprint: TIG 2018-03-26
Participants:

 Comments   
Comment by Robert Guo (Inactive) [ 07/Mar/18 ]

I don't think so. Closing as dupe.

Comment by Max Hirschhorn [ 07/Mar/18 ]

The "benchmarks" target was explicitly added to the SCons invocation in the compile_all task with 721846a as part of SERVER-33203. robert.guo, is there anything else this ticket was meant to cover given Mathias's changes from 8a275d2 as part of SERVER-33491?

Comment by Andrew Morrow (Inactive) [ 07/Feb/18 ]

I think long term we will absolutely need the microbenchmarks to compile with icecream, but I'm OK leaving them out of the all target for now, as long as we explicitly add the 'benchmarks' target to the SCons invocations for the compile_all phase on evergreen, so that we know they don't bitrot.

Comment by Max Hirschhorn [ 07/Feb/18 ]

robert.guo, I'd like to understand acm's opinion on whether he'd want the C++ microbenchmarks to be compiled as part of the "all" target in order to know if we eventually need to do this work or not.

Comment by Robert Guo (Inactive) [ 07/Feb/18 ]

I'm punting this ticket for now. The fix is to create a one line patch but I'd like to get a better sense of whether compiling with icecream will contribute to noise in the tests before moving forward with this.

The original purpose for this ticket was to prevent people from running into this issue when compiling "all", which is no longer the case with benchmark taken out of the "all" target

Generated at Thu Feb 08 04:31:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.