[SERVER-32958] Convert simple Command member functions to new signatures Created: 29/Jan/18  Updated: 29/Oct/23  Resolved: 01/Feb/18

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 3.7.2

Type: Improvement Priority: Minor - P4
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Platforms 2018-01-29, Platforms 2018-02-12
Participants:

 Description   

Some Command member functions are undergoing small changes in the TypedCommand proposal. For those member functions, it's easier to bulk-migrate the ~200 subclasses than to execute a staged migration plan.

Example:

void help(std::stringstream&) const

becomes

std::string help() const



 Comments   
Comment by Githook User [ 01/Feb/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-32958 small changes to remaining Command member signatures.
Branch: master
https://github.com/mongodb/mongo/commit/62ca1bcdd3dcc634a6fa91204b0f0941eb76399e

Comment by Githook User [ 01/Feb/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-32958 restore LogRotateCmd's adminOnly override.

(was accidentally deleted by recent
40e43aca44d4dd251b7a1d0ce44c7cb49dcda93f )
Branch: master
https://github.com/mongodb/mongo/commit/255b7bfbd5d8a566b52c70f9209f82067afdedca

Comment by Githook User [ 31/Jan/18 ]

Author:

{'email': 'golden.janna@gmail.com', 'name': 'jannaerin', 'username': 'jannaerin'}

Message: SERVER-32958 Re-remove forceerror command
Branch: master
https://github.com/mongodb/mongo/commit/ea3411cdff940e034c798f39584293594dfcb0de

Comment by Githook User [ 31/Jan/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-32958 reorder headers
Branch: master
https://github.com/mongodb/mongo/commit/bc6922fbb1a22ee93ca6f5d618527c989fdcbee7

Comment by Githook User [ 31/Jan/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-32958 unrevert "SERVER-32958 slaveOk,slaveOverrideOk replacement"

w/fix: update a new command to secondaryAllowed

This reverts commit d75cb425fbc3cf4b569eb1722c3f8abec45654a2.
Branch: master
https://github.com/mongodb/mongo/commit/40e43aca44d4dd251b7a1d0ce44c7cb49dcda93f

Comment by Githook User [ 31/Jan/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-32958 unrevert "SERVER-32958 slaveOk,slaveOverrideOk replacement"

w/fix: update a new command to secondaryAllowed

This reverts commit d75cb425fbc3cf4b569eb1722c3f8abec45654a2.
Branch: master
https://github.com/mongodb/mongo/commit/40e43aca44d4dd251b7a1d0ce44c7cb49dcda93f

Comment by Githook User [ 31/Jan/18 ]

Author:

{'email': 'judah@mongodb.com', 'name': 'Judah Schvimer', 'username': 'judahschvimer'}

Message: Revert "SERVER-32958 slaveOk,slaveOverrideOk replacement"

This reverts commit be24b0323d3f2d424d9e22337f4221d39001ac31.
Branch: master
https://github.com/mongodb/mongo/commit/d75cb425fbc3cf4b569eb1722c3f8abec45654a2

Comment by Githook User [ 31/Jan/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-32958 slaveOk,slaveOverrideOk replacement
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/04ae570e1be5a8ac5a1a4babec12fe29289da001

Comment by Githook User [ 31/Jan/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-32958 slaveOk,slaveOverrideOk replacement

declare read_preference dep. update service_entry_opint_embedded
Branch: master
https://github.com/mongodb/mongo/commit/be24b0323d3f2d424d9e22337f4221d39001ac31

Comment by Githook User [ 30/Jan/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-32958 Command::help() returns std::string
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/f0c05ba63cfe0c6fa4086b409425e35585b8e15f

Comment by Githook User [ 30/Jan/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-32958 Command::help() returns std::string
Branch: master
https://github.com/mongodb/mongo/commit/0700f1dc9c9f9985962d96f6aef6200a3a5bd57d

Generated at Thu Feb 08 04:31:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.