[SERVER-32984] clean up DatabaseType class Created: 29/Jan/18 Updated: 29/Oct/23 Resolved: 05/Feb/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | 3.7.1 |
| Fix Version/s: | 3.7.2 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Esha Maharishi (Inactive) | Assignee: | Esha Maharishi (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Sharding 2018-02-12 |
| Participants: |
| Description |
|
This class has several fields that are boost::optional, but are actually required, and other messy details that should be cleaned up before adding functionality to this class for database versioning. |
| Comments |
| Comment by Githook User [ 05/Feb/18 ] |
|
Author: {'email': 'esha.maharishi@mongodb.com', 'name': 'Esha Maharishi', 'username': 'EshaMaharishi'}Message: |
| Comment by Esha Maharishi (Inactive) [ 29/Jan/18 ] |
|
Done - |
| Comment by Kaloian Manassiev [ 29/Jan/18 ] |
|
Sounds good to me. |
| Comment by Esha Maharishi (Inactive) [ 29/Jan/18 ] |
|
Not a bad idea. From a quick search, it looks like it's used in a lot of places, and I'm already running an Evergreen patch for the clean up I did. Mind if I create a separate ticket to rewrite it with the IDL, and put it in the epic? |
| Comment by Kaloian Manassiev [ 29/Jan/18 ] |
|
Should we just try to IDL-ify this class? Eventually all sharding type classes should be IDL, but since this one is the simplest, maybe we can start with it. |