[SERVER-33065] create CommandReplyBuilder and CommandInvocation Created: 01/Feb/18  Updated: 29/Oct/23  Resolved: 06/Mar/18

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 3.7.3

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-33495 Command::explain must take OpMsgReque... Closed
Backwards Compatibility: Fully Compatible
Participants:

 Description   

Create CommandReplyBuilder and CommandInvocation,
and add the Command::parse to return a unique_ptr<CommandInvocation>.

A baby-step' CommandInvocation will be Command::Invocation,
which just forwards everything to existing Command member functions.

This ticket includes wiring up the service_entry_point_mongod to use
Command::parse.



 Comments   
Comment by Githook User [ 06/Mar/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-33065 CommandReplyBuilder and CommandInvocation

Revert "Revert "SERVER-33065 CommandReplyBuilder and CommandInvocation""
This reverts commit 74177edb35b6ce7594e4751051010ceade592484.
Leave out the unintentional repl/ change this time.
Branch: master
https://github.com/mongodb/mongo/commit/e3a3f54a6c0ec4f471e0aff7a48b8a30f8c0e9cb

Comment by Githook User [ 06/Mar/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-33065 CommandReplyBuilder and CommandInvocation

Revert "Revert "SERVER-33065 CommandReplyBuilder and CommandInvocation""
This reverts commit 74177edb35b6ce7594e4751051010ceade592484.
Leave out the unintentional repl/ change this time.
Branch: master
https://github.com/mongodb/mongo/commit/e3a3f54a6c0ec4f471e0aff7a48b8a30f8c0e9cb

Comment by Githook User [ 05/Mar/18 ]

Author:

{'email': 'nicholas.zolnierz@mongodb.com', 'name': 'Nick Zolnierz', 'username': 'nzolnierzmdb'}

Message: Revert "SERVER-33065 CommandReplyBuilder and CommandInvocation"

This reverts commit ad94e51e0dd40b0d0c38215a36caf75a4be48415.
Branch: master
https://github.com/mongodb/mongo/commit/74177edb35b6ce7594e4751051010ceade592484

Comment by Githook User [ 02/Mar/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-33065 CommandReplyBuilder and CommandInvocation

remove publicRun from mr_test.cpp
change explain to take OpMsgRequest
private explain
private allowsAfterClusterTime
private supportsWriteConcern supportsReadConcern
remove publicRun
cluster_explain_cmd.cpp: do not inject "$db" field.
let explain() exceptions escape
update cluster distinct explain
Branch: master
https://github.com/mongodb/mongo/commit/ad94e51e0dd40b0d0c38215a36caf75a4be48415

Comment by Billy Donahue [ 27/Feb/18 ]

Code Review: http://mongodbcr.appspot.com/191300001

Comment by Billy Donahue [ 15/Feb/18 ]

Part 2: remove publicRun
http://mongodbcr.appspot.com/191130002

Comment by Billy Donahue [ 14/Feb/18 ]

Reapplied cr181880001 on master after SERVER-33214 to produce cr193060001
Code Review: https://mongodbcr.appspot.com/193060001

Comment by Billy Donahue [ 12/Feb/18 ]

New review for after SERVER-33214
Code Review: http://mongodbcr.appspot.com/190080001

Comment by Billy Donahue [ 01/Feb/18 ]

Code Review: http://mongodbcr.appspot.com/181880001

Generated at Thu Feb 08 04:32:10 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.