[SERVER-33077] checkReplicatedDataHashes should provide more information if a collection doesn't exist Created: 02/Feb/18 Updated: 29/Oct/23 Resolved: 01/Mar/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 3.6.9, 3.7.3 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Judah Schvimer | Assignee: | Jonathan Abrahams |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Backport Requested: |
v3.6
|
||||||||
| Sprint: | TIG 2018-02-26, TIG 2018-03-12 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 0 | ||||||||
| Description |
|
We fail here if the collection doesn't exist on the secondary and then don't get any more information, but collections being missing are exactly what this is looking for. |
| Comments |
| Comment by Githook User [ 20/Sep/18 ] |
|
Author: {'name': 'Jonathan Abrahams', 'email': 'jonathan@mongodb.com', 'username': 'hptabster'}Message: (cherry picked from commit 65c1e94b0187adb8606e571d02658f3a130f2164) |
| Comment by Githook User [ 01/Mar/18 ] |
|
Author: {'email': 'jonathan@mongodb.com', 'name': 'Jonathan Abrahams', 'username': 'hptabster'}Message: |
| Comment by Jonathan Abrahams [ 12/Feb/18 ] |
|
Per discussion, if a collection does not exist on another node, ensure that we print out as much information from the collection that does exist, before triggering a test failure. |
| Comment by Judah Schvimer [ 07/Feb/18 ] |
|
This line is also a problem for missing collections: https://github.com/mongodb/mongo/blob/34d2da2cfb93244818ecb55843f58d359151198d/src/mongo/shell/replsettest.js#L1389 |
| Comment by Judah Schvimer [ 02/Feb/18 ] |
|
One potentially sufficient improvement could be to make dumpCollectionDiff print out coll stats and collection options for collections that are different or missing. |
| Comment by Judah Schvimer [ 02/Feb/18 ] |
|
We also don't print out collection information (like the UUID most importantly) for collections that are missing: https://github.com/mongodb/mongo/blob/1b4ae523b52673cbad589870ebc79cd55a4fe6a4/src/mongo/shell/replsettest.js?utf8=%E2%9C%93#L1502-L1503. |