[SERVER-33214] ServiceEntryPointCommon Created: 09/Feb/18  Updated: 29/Oct/23  Resolved: 14/Feb/18

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 3.7.3

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Participants:

 Description   

Unfork ServiceEntryPointMongod and ServiceEntryPointEmbedded.
Allowing these complex service implementations to diverge is dangerous.



 Comments   
Comment by Githook User [ 14/Feb/18 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-33214 ServiceEntryPointCommon
common base for service_entry_point_embedded and
service_entry_point_mongod.

Use the deps of service_entry_point_embedded as
a starting point for the deps of service_entry_point_common.
Branch: master
https://github.com/mongodb/mongo/commit/87a217c70c86a9cd1a3ff1622caefc147b110144

Comment by Billy Donahue [ 09/Feb/18 ]

They already diverged a little.
https://github.com/mongodb/mongo/commit/4ec29b020efe0909b561b671f4f4cd202a4d8bab#diff-727fa921135d16e4c3d0b4c0b2939b1dL450

The current state of things is that I will have to do the very tricky Command dispatch twice, so I'm volunteering here to install the mechanism to make the divergences explicit through a hook mechanism, because I need that right away.

Comment by Andrew Morrow (Inactive) [ 09/Feb/18 ]

They were forked so that the embedded one could be stripped down, and we just started that process. Once we have minimized it though, I'd support commoning out what remains common between it and the server one into a shared base.

Generated at Thu Feb 08 04:32:41 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.