[SERVER-33261] jstests/core/views/views_all_commands.js fails with --use-cpu-profiler enabled Created: 12/Feb/18  Updated: 29/Oct/23  Resolved: 04/Jun/18

Status: Closed
Project: Core Server
Component/s: Querying, Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.0.0, 4.1.1

Type: Improvement Priority: Major - P3
Reporter: David Bartley Assignee: Benjamin Caimano (Inactive)
Resolution: Fixed Votes: 0
Labels: neweng, read-only-views
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-35181 MongoDB 4.0 does not build with --use... Closed
related to SERVER-33259 Include libunwind in src/third_party Closed
Backwards Compatibility: Fully Compatible
Participants:

 Description   

Even with a fixed libunwind (https://jira.mongodb.org/browse/SERVER-33259), tests still don't pass because views_all_commands.js doesn't skip _cpuProfilerStart and _cpuProfilerStop in viewsCommandTests.



 Comments   
Comment by Benjamin Caimano (Inactive) [ 04/Jun/18 ]

This should be fixed by this commit

Comment by David Bartley [ 13/Feb/18 ]

We run buildscripts/resmoke.py --suites --suites unittests,dbtest,core,concurrency,master_slave,integration_tests_replset,integration_tests_sharded,integration_tests_standalone,no_passthrough,replica_sets,sharding to get some basic test coverage/assurance that our builds aren't totally broken.

Comment by Kyle Suarez [ 13/Feb/18 ]

Hi bartle,

Thanks for reporting this. You're right that we don't have an Evergreen variant that runs with --use-cpu-profiler, so this test passes in CI as-is because _cpuProfilerStart is not reported as a command by the server in any jscore passthrough variant. There are also a number of other tests that have assertions about having coverage for every possible command; if we update this test, we should update all of them:

  • views_all_commands.js
  • commands_lib.js
  • jstests/sharding/safe_secondary_reads_drop_recreate.js
  • jstests/sharding/safe_secondary_reads_single_migration_suspend_range_deletion.js
  • jstests/sharding/safe_secondary_reads_single_migration_waitForDelete.js

Out of curiosity, under what configuration were you testing MongoDB?

Regards,
Kyle

CC max.hirschhorn

Comment by David Bartley [ 12/Feb/18 ]

Also, it'd be good if there were an evergreen configuration that ran tests with --use-cpu-profiler.

Generated at Thu Feb 08 04:32:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.