[SERVER-33302] Missing log redaction for a few failure paths Created: 13/Feb/18 Updated: 29/Oct/23 Resolved: 20/Feb/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying |
| Affects Version/s: | 3.6.2 |
| Fix Version/s: | 3.6.4, 3.7.3 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Ramon Fernandez Marina | Assignee: | David Storch |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||
| Backport Requested: |
v3.6
|
||||||||||||||||||||
| Sprint: | Query 2018-02-26 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Case: | (copied to CRM) | ||||||||||||||||||||
| Description |
| Comments |
| Comment by Githook User [ 23/Feb/18 ] |
|
Author: {'email': 'david.storch@10gen.com', 'name': 'David Storch', 'username': 'dstorch'}Message: (cherry picked from commit 6b08990f795c3521465ea096fd6e898b6fedd51b) Conflicts: |
| Comment by Githook User [ 20/Feb/18 ] |
|
Author: {'email': 'david.storch@10gen.com', 'name': 'David Storch', 'username': 'dstorch'}Message: |
| Comment by David Storch [ 20/Feb/18 ] |
|
It appears that Command::redactForLogging() predates the --redactClientLogData feature. Confusingly, the two are unrelated. The latter was introduced in 3.4, and when enabled, strips any PII from the logs. The former, on the other hand, is always enabled, and is used to strip password data (as well as to avoid overlong write command lines). This bug seems to be the direct result of this confusion during the implementation of --redactClientLogData, so I'll try to leave some clarifying comments. |