[SERVER-33323] Refactor $mergeCursors stage to allow it to be used to merge cursors on mongos Created: 14/Feb/18 Updated: 29/Oct/23 Resolved: 20/Aug/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Aggregation Framework |
| Affects Version/s: | None |
| Fix Version/s: | 4.1.3 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Charlie Swanson | Assignee: | Charlie Swanson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||
| Sprint: | Query 2018-03-12, Query 2018-03-26, Query 2018-07-02, Query 2018-07-16, Query 2018-07-30, Query 2018-08-13, Query 2018-08-27 | ||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||
| Linked BF Score: | 75 | ||||||||||||||||||||||||||||
| Description |
|
This can be done as follow-on work after Once the $mergeCursors stage is using the AsyncResultsMerger, we can collapse that picture and eliminate the DocumentSourceRouterAdapter and RouterStageMerge. |
| Comments |
| Comment by Githook User [ 20/Aug/18 ] |
|
Author: {'name': 'Charlie Swanson', 'email': 'charlie.swanson@mongodb.com', 'username': 'cswanson310'}Message: Attempts to make it more obvious how commands for the shards are |
| Comment by Githook User [ 20/Aug/18 ] |
|
Author: {'name': 'Charlie Swanson', 'email': 'charlie.swanson@mongodb.com', 'username': 'cswanson310'}Message: This new library contains both cluster_aggregate.cpp and |
| Comment by Githook User [ 15/Aug/18 ] |
|
Author: {'name': 'Siyuan Zhou', 'email': 'siyuan.zhou@mongodb.com', 'username': 'visualzhou'}Message: |
| Comment by Githook User [ 15/Aug/18 ] |
|
Author: {'username': 'cswanson310', 'email': 'charlie.swanson@mongodb.com', 'name': 'Charlie Swanson'}Message: This commit makes it so that aggregations will always use a |
| Comment by Charlie Swanson [ 06/Apr/18 ] |
|
Recent commits should have fixed the failures that lead to the revert. Putting this back in Needs Triage. |
| Comment by Githook User [ 06/Apr/18 ] |
|
Author: {'email': 'charlie.swanson@mongodb.com', 'name': 'Charlie Swanson', 'username': 'cswanson310'}Message: Check if the pipeline is empty before setting the new stage to point to Remove unnecessary const qualifier from std::size_t return types. Work around a compiler bug on s390x by allowing a CursorResponse to be |
| Comment by Githook User [ 06/Apr/18 ] |
|
Author: {'email': 'charlie.swanson@mongodb.com', 'name': 'Charlie Swanson', 'username': 'cswanson310'}Message: |
| Comment by William Schultz (Inactive) [ 05/Apr/18 ] |
|
Author: {'email': 'william.schultz@mongodb.com', 'name': 'William Schultz', 'username': 'will62794'}Message: Fix merge conflict errors Branch: master |
| Comment by Githook User [ 05/Apr/18 ] |
|
Author: {'email': 'william.schultz@mongodb.com', 'name': 'William Schultz', 'username': 'will62794'}Message: Revert " This reverts commit 7d09f278a2acf9791b36927d6af1d30347d60391. |
| Comment by Charlie Swanson [ 04/Apr/18 ] |
|
We've committed part one of this refactor, which has the benefit of allowing us to delete some old code as soon as we stop supporting 3.6 mongos. The work outlined in this ticket is not done though. I'm throwing this back into Needs Triage and shifting focus elsewhere for now. |
| Comment by Githook User [ 04/Apr/18 ] |
|
Author: {'email': 'charlie.swanson@mongodb.com', 'name': 'Charlie Swanson', 'username': 'cswanson310'}Message: |
| Comment by Githook User [ 04/Apr/18 ] |
|
Author: {'email': 'mark.benvenuto@mongodb.com', 'name': 'Mark Benvenuto', 'username': 'markbenvenuto'}Message: Signed-off-by: Charlie Swanson <charlie.swanson@mongodb.com> |
| Comment by Charlie Swanson [ 06/Mar/18 ] |
|
Code review for refactor: https://mongodbcr.appspot.com/193390001/ This patch just uses the IDL to serialize/deserialize the AsyncResultsMerger, and does not include all the changes described in this ticket. More to come later. |
| Comment by Charlie Swanson [ 14/Feb/18 ] |
|
david.storch I tentatively assigned this to myself for next sprint. We can re-evaluate at the next sprint planning to see if that still makes sense, but hopefully it will. The alternative is leaving it on the backlog user and in the epic until Also, it's not technically required for the epic, so feel free to take it out if you'd like. |