[SERVER-33358] Inline ClientCursorPin dassert boolean to prevent unecessary work on non-debug builds Created: 15/Feb/18 Updated: 29/Oct/23 Resolved: 27/Feb/18 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying |
| Affects Version/s: | None |
| Fix Version/s: | 3.7.3 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Charlie Swanson | Assignee: | Charlie Swanson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Query 2018-02-26, Query 2018-03-12 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 0 | ||||||||
| Description |
|
this line is intended to check that the caller is holding the appropriate locks. I have no hard proof that it is running in our release builds, but when I was doing local performance profiling on a non-debug build it was showing up. It doesn't hurt legibility too much to inline it. |
| Comments |
| Comment by Githook User [ 27/Feb/18 ] |
|
Author: {'email': 'charlie.swanson@mongodb.com', 'name': 'Charlie Swanson', 'username': 'cswanson310'}Message: The check of the lock state was showing up in a performance trace of a |