[SERVER-33429] add database versioning test cases for commands not tracked by the profiler Created: 21/Feb/18  Updated: 29/Oct/23  Resolved: 11/Apr/18

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 3.7.4

Type: Task Priority: Major - P3
Reporter: Esha Maharishi (Inactive) Assignee: Janna Golden
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-33499 Consolidate CurOp initialization Backlog
Duplicate
is duplicated by SERVER-34406 blacklist database_and_shard_versioni... Closed
Related
is related to SERVER-33339 add jstest that documents and verifie... Closed
Backwards Compatibility: Fully Compatible
Sprint: Sharding 2018-04-09, Sharding 2018-04-23
Participants:

 Description   

The jstest created in SERVER-33339 left out test cases that define whether a dbVersion is sent for:

  • copydb
  • createIndexes
  • drop (collection)
  • dropDatabase
  • listCollections
  • renameCollection
  • validate

These commands should be tested separately, since they cannot be tested by using the profiler.

Additionally,

  • update
  • delete

should be tested separately, since they are batched and the profiler only captures individual updates/deletes within the batch, so it loses any fields on the outer command.



 Comments   
Comment by Githook User [ 11/Apr/18 ]

Author:

{'email': 'golden.janna@gmail.com', 'name': 'jannaerin', 'username': 'jannaerin'}

Message: SERVER-33429 Add database versioning test cases for commands not tracked by the profiler
Branch: master
https://github.com/mongodb/mongo/commit/b299eabdf833eb85c2f205c847d6fc38910aefb1

Comment by Githook User [ 09/Apr/18 ]

Author:

{'email': 'william.schultz@mongodb.com', 'name': 'William Schultz', 'username': 'will62794'}

Message: Revert "SERVER-33429 Add database versioning test cases for commands not tracked by the profiler"

This reverts commit 56f3d3dc9cc88edc46e4e0cf150462ba9f554fe7.
Branch: master
https://github.com/mongodb/mongo/commit/a6b025a454f2f46be1809761a091bc889c8ba2a6

Comment by Githook User [ 07/Apr/18 ]

Author:

{'email': 'blake.oler@mongodb.com', 'name': 'Blake Oler', 'username': 'BlakeIsBlake'}

Message: SERVER-33429 Add database versioning test cases for commands not tracked by the profiler
Branch: master
https://github.com/mongodb/mongo/commit/56f3d3dc9cc88edc46e4e0cf150462ba9f554fe7

Comment by Esha Maharishi (Inactive) [ 05/Apr/18 ]

Since SERVER-33499 may not be completed in time for 4.0, and the jstest now check that these commands check the databaseVersion a second way (by checking that the command worked and, after the command ran, the shard's cached databaseVersion was updated), we should be able to just add test cases for these commands in the jstest.

Comment by Esha Maharishi (Inactive) [ 08/Mar/18 ]

Note, SERVER-33499 should make all of the collection-level operations listed above start getting profiled, so this ticket may just need to add test cases for them to the jstest.

Generated at Thu Feb 08 04:33:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.