[SERVER-33608] Don't use ${project} in system_perf.yml Created: 02/Mar/18  Updated: 27/Oct/23  Resolved: 20/Jun/18

Status: Closed
Project: Core Server
Component/s: Performance
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Henrik Ingo (Inactive) Assignee: Julian Edwards
Resolution: Gone away Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
is caused by SERVER-25348 Parameterize branch in etc/system-per... Closed
Participants:

 Description   

In SERVER-25348 we have introduced an expansion ${project} in system_perf.yml. Turns out it is a builtin Evergreen expansion. So we should use something else.

AFAIU we could simply remove the setting of this expansion, and use the value from the builtin expansion? We set it to "dsi", "dsi-v3.6", etc... and the builtin would be "sys-perf", "sys-perf-3.6"...



 Comments   
Comment by Julian Edwards [ 20/Jun/18 ]

Fix baked in with work done in SERVER-35108.

Comment by Julian Edwards [ 20/Jun/18 ]

Yes, I changed `project` to `project_dir` in system_perf.yml with SERVER-35108. In perf.yml `project` is still used incorrectly but that should get fixed when we do SERVER-35109.

Comment by Henrik Ingo (Inactive) [ 20/Jun/18 ]

I think julian.edwards baked it into some other work?

Comment by David Daly [ 06/Mar/18 ]

This would involve removing lines like this and this from system_perf.yml and making sure everything still works. Hopefully that just works. If it does not, we should change the name project to something else throughout this file, and set that to avoid the conflict with the evergreen default expansion.

Generated at Thu Feb 08 04:33:59 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.