[SERVER-33647] Enterprise Windows 2008R2 WiredTiger develop shouldn't run the push task Created: 03/Mar/18 Updated: 04/Dec/23 Resolved: 04/Dec/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build, WiredTiger |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Max Hirschhorn | Assignee: | [DO NOT ASSIGN] Backlog - DevProd Build |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | stm | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Assigned Teams: |
Build
|
||||||||||||||||||||||||||||||||
| Sprint: | Storage Non-NYC 2018-03-12, Storage Non-NYC 2018-03-26, Storage Non-NYC 2018-05-07 | ||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||||||||||||||||||
| Story Points: | 2 | ||||||||||||||||||||||||||||||||
| Description |
|
Originally, I had thought that not setting push_path, push_bucket, push_name, and push_arch in the Enterprise Windows 2008R2 WiredTiger develop builder's expansions would be sufficient to make the "push" Evergreen task a no-op; however, I have learned that go-yaml/yaml has known behavior differences in how the merge key "<<:" is implemented (see go-yaml/yaml#81 and go-yaml/yaml#325) that cause it inherit the Enterprise Windows 2008R2 builder's configuration via the enterprise-windows-64-2k8-template anchor. This means that when the "push" task runs on the Enterprise Windows 2008R2 WiredTiger develop builder, the binaries are being uploaded to the same S3 path. The releases for MongoDB happen via the mongo-release Evergreen project, so this issue only impacts the contents of the -latest nightly releases. |
| Comments |
| Comment by Mikhail Shchatko [ 04/Dec/23 ] |
|
steve.gross@mongodb.com I see that this particular issue has been fixed by |
| Comment by Max Hirschhorn [ 02/May/19 ] |
|
Moving this over to DAG because I'm thinking the project to have task lists always expressed using Evergreen task selectors (tags) will establish a better pattern for sharing nearly identical lists of tasks without some accidentally overwriting release binaries. |
| Comment by Max Hirschhorn [ 10/May/18 ] |
|
I've moved this ticket over to the TIG team for the changes from 11a3d5c to be recommitted after |
| Comment by Githook User [ 09/May/18 ] |
|
Author: {'email': 'jonathan@mongodb.com', 'name': 'Jonathan Abrahams', 'username': 'hptabster'}Message: Revert " This reverts commit 11a3d5ccb1216da0e84d941fd48e486f72455ba4. |
| Comment by Githook User [ 09/May/18 ] |
|
Author: {'email': 'luke.chen@mongodb.com', 'name': 'Luke Chen', 'username': 'lukech'}Message: |
| Comment by Githook User [ 04/May/18 ] |
|
Author: {'email': 'luke.chen@mongodb.com', 'name': 'Luke Chen', 'username': 'lukech'}Message: |
| Comment by Alexander Gorrod [ 01/May/18 ] |
|
Sounds good to me. |
| Comment by Luke Chen [ 27/Apr/18 ] |
|
There's one task "burn_in_tests" failed in the patch build. The test script buildscripts/ciconfig/evergreen.py was having difficulty understanding task selectors. |
| Comment by Luke Chen [ 26/Apr/18 ] |
|
I created a patch build today by following the task selector syntax suggested in EVG-2989. It managed to provide different distros to different tasks in "Windows 2008R2 DEBUG WiredTiger develop" variant. https://evergreen.mongodb.com/version/5ae1639dc9ec44641fd52543 |
| Comment by Luke Chen [ 16/Mar/18 ] |
|
ramon.fernandez max.hirschhorn, looks we'd need to hold off the "task tagging" approach until EVG-2989 is implemented. To address the issue immediately in front of us, I'd suggest to have both "Enterprise Windows 2008R2 WiredTiger (inMemory) develop" and "Windows 2008R2 DEBUG WiredTiger develop" variants created to replace existing "Enterprise Windows 2008R2 WiredTiger develop" variant, so that we still have coverage for Enterprise modules and not losing any tasks. Please let me know your opinions. Cheers. |
| Comment by Alexander Gorrod [ 04/Mar/18 ] |
|
The reason we chose Windows Enterprise was to get testing of enterprise modules - which includes the in-memory storage engine and encryption extension that are based on WiredTiger. I'd prefer to keep at least one enterprise based build in the list of WiredTiger develop based variants. |
| Comment by Max Hirschhorn [ 03/Mar/18 ] |
|
Per some additional feedback from ramon.fernandez, it'd be beneficial to avoid writing hacks in the release tooling if the Enterprise Windows 2008R2 WiredTiger develop builder didn't run the "push" task at all. luke.chen, alexander.gorrod, would you both be okay with using the task list from the Windows 2008R2 DEBUG builder? It is likely only a superset of what the Enterprise Windows 2008R2 WiredTiger develop is currently running (modulo the "push" task of course). |