[SERVER-3366] ! NumberInt(0) is broken Created: 05/Jul/11 Updated: 12/Jul/16 Resolved: 06/Jul/11 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | JavaScript |
| Affects Version/s: | None |
| Fix Version/s: | 1.9.1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Eliot Horowitz (Inactive) | Assignee: | Antoine Girbal |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Operating System: | ALL |
| Participants: |
| Description |
|
see jstests/numberint.js |
| Comments |
| Comment by Antoine Girbal [ 06/Jul/11 ] |
|
ok I fixed the behavior in SM, see |
| Comment by Antoine Girbal [ 06/Jul/11 ] |
|
ok I fixed the behavior in SM, see |
| Comment by Eliot Horowitz (Inactive) [ 06/Jul/11 ] |
|
Should do this before 1.9.1 is release as could break things in bad ways. |
| Comment by Eliot Horowitz (Inactive) [ 06/Jul/11 ] |
|
What's really important is normal document road tripping - i.e. load modify save, and having an explicit way to create one. So I think #2 is good. |
| Comment by Antoine Girbal [ 06/Jul/11 ] |
|
the Integer is an internal C++ class.
|
| Comment by Eliot Horowitz (Inactive) [ 06/Jul/11 ] |
|
In v8 it seems there is an Integer class? |
| Comment by Antoine Girbal [ 06/Jul/11 ] |
|
I see that you assigned it to 1.9.2. possible solutions: 2) make the use of integer implicit. 3) use v8 and modify source to change behavior of "!" to call a method if an object. |
| Comment by Eliot Horowitz (Inactive) [ 06/Jul/11 ] |
|
Yes - its currently breaking various unit tests, so certainly could break a lot of code in the wild with possibly disastrous consequences. |
| Comment by Antoine Girbal [ 06/Jul/11 ] |
|
I doubt it. what case do you think it may be an issue? |
| Comment by Eliot Horowitz (Inactive) [ 06/Jul/11 ] |
|
Is it fixable in v8? |
| Comment by Antoine Girbal [ 05/Jul/11 ] |
|
not sure that this is fixable.. |
| Comment by auto [ 05/Jul/11 ] |
|
Author: {u'login': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}Message: |