[SERVER-33665] Tests run by hooks should be TestCase subclasses Created: 05/Mar/18  Updated: 29/Oct/23  Resolved: 07/Mar/18

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 3.7.3

Type: Improvement Priority: Major - P3
Reporter: Yves Duhem Assignee: Yves Duhem
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
causes SERVER-33737 DynamicJSTestCase logger does not get... Closed
causes SERVER-34185 Failure of data consistency checks ru... Closed
Backwards Compatibility: Fully Compatible
Sprint: TIG 2018-03-12
Participants:

 Description   

When hooks run dynamic tests they handle the calls to report methods (startTest(), endTest(), etc.), the execution of the tests and error handling. Several hooks have implemented the same logic in similar but not identical ways.

A subclass of TestCase specific to dynamic tests will be added to handle this logic. Each hook will then be updated to have their own TestCase implementations.

To support these changes, the TestCase code that is specific to process based tests (i.e. _execute(), _make_process()) will be moved to a subclass.



 Comments   
Comment by Githook User [ 07/Mar/18 ]

Author:

{'email': 'yves.duhem@mongodb.com', 'name': 'Yves Duhem', 'username': 'syev'}

Message: SERVER-33665 Call configure on ProcessTestCase
Branch: master
https://github.com/mongodb/mongo/commit/4b80b74a6182af8fe4a0886e97dbb43802d2b88a

Comment by Max Hirschhorn [ 07/Mar/18 ]

yves.duhem, it doesn't look like all of the calls to interface.TestCase.configure() were updated to be interface.ProcessTestCase.configure() in the derived classes that were changed to use interface.ProcessTestCase as their base.

Comment by Githook User [ 06/Mar/18 ]

Author:

{'email': 'yves.duhem@mongodb.com', 'name': 'Yves Duhem', 'username': 'syev'}

Message: SERVER-33665 Make hook dynamic tests TestCase instances
Branch: master
https://github.com/mongodb/mongo/commit/d0cadc1fa1571ce92d83dab34a65da0a2b407cac

Comment by Githook User [ 06/Mar/18 ]

Author:

{'email': 'yves.duhem@mongodb.com', 'name': 'Yves Duhem', 'username': 'syev'}

Message: SERVER-33665 New TestCase subclass for process based tests
Branch: master
https://github.com/mongodb/mongo/commit/10f20885724344c628cb0e9d05e365c3cc690de4

Generated at Thu Feb 08 04:34:11 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.