[SERVER-33679] Forward declare OperationContext in read_concern_args.h Created: 05/Mar/18  Updated: 29/Oct/23  Resolved: 29/Jun/18

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.1.1

Type: Improvement Priority: Minor - P4
Reporter: Xiangyu Yao (Inactive) Assignee: Dewal Gupta
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Storage NYC 2018-07-02
Participants:

 Description   

read_concern_args.h does not need to include the operation_context.h. Instead of declaring the decoration getter in the header, we could move the decoration getter into the .cpp so that the header does not need to include the OperationContext.

This can improve potential circular dependency issues because it does not make sense to have read_concern_args depend on operation_context.

The work will include moving the decoration getter from .h to .cpp and adding read_concern_args as a dependency to all the tests/lib that use the decoration getter since the header will not have an implementation.



 Comments   
Comment by Githook User [ 28/Jun/18 ]

Author:

{'username': 'dewalg', 'name': 'Dewal Gupta', 'email': 'dewal.gupta@10gen.com'}

Message: SERVER-33679 Forward declare OperationContext in read_concern_args.h
Branch: master
https://github.com/mongodb/mongo/commit/0889a7e2b592f443d9bfedb320e852c150bc5b14

Generated at Thu Feb 08 04:34:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.